My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2478: Show coverage information in the diff view
9 people starred this issue and may be notified of changes. Back to list
Status:  Duplicate
Merged:  issue 3538
Owner:  ----
Closed:  Dec 14


Sign in to add a comment
 
Reported by magnus.reftel, Feb 14, 2014
It would be great if it was possible to upload some code coverage information from a test run to Gerrit, and have it highlight changed lines that were not hit by the tests in the diff views. That way, reviewers know what to pay extra attention to.
Feb 23, 2014
Project Member #1 david.pu...@sonymobile.com
In the "Set Review" REST API [1] comments can be added on a specific line by setting the `line` (and optionally the `range`) values on the `CommentInput` entity [2].

Using this, it should be fairly easy to implement something that pushes the necessary code coverage information as a Gerrit review comment.


[1] https://gerrit-documentation.storage.googleapis.com/Documentation/2.8/rest-api-changes.html#set-review

[2] https://gerrit-documentation.storage.googleapis.com/Documentation/2.8/rest-api-changes.html#comment-input

Status: AwaitingInformation
Mar 31, 2015
#2 l.brueni...@googlemail.com
A comment would not give a good integration IMHO, it would be better if it is integrated directly in the code lines as can be seen here http://googletesting.blogspot.de/2014/07/measuring-coverage-at-google.html
Mar 31, 2015
#3 magnus.reftel
Thanks for the link! That's exactly the kind of visualization I was thinking of.

I don't really have any opinions on whether code coverage is best reported via upload of coverage files or by API calls for marking up lines. The data visualization is what matters to me.
Dec 14, 2015
Project Member #4 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: Duplicate
Mergedinto: 3538
Sign in to add a comment

Powered by Google Project Hosting