My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2474: Inconsistent data displayed in the old change screen
4 people starred this issue and may be notified of changes. Back to list
Status:  AwaitingInformation
Owner:  ----


Sign in to add a comment
 
Reported by jhabib1...@gmail.com, Feb 13, 2014
************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version:
2.8.1
What steps will reproduce the problem?
1. create new code review with few reviewers
2. Reviewer review the code and add comments
3. Modifications will be displayed in the Comments section, but not on top in the score table.

What is the expected output? What do you see instead?
The change screen should reflect and display updates in both sections:
- The score table on top and the Comments section at the bottom.

Please provide any additional information below.

Feb 17, 2014
Project Member #1 David.Os...@gmail.com
Can not reproduce it (stable-2.8 branch: 2.8.1-54-g194a69d):

* upload a change
* add reviewers
* vote on change per ssh server gerrit review --code-review ... for different accounts
* reload change:
click on permalink or go to change list and enter the change again:

as expected, both parts are refreshed: Scorse and comment table.

Can you provide exact steps how to reproduce it?
Status: AwaitingInformation
Feb 18, 2014
Project Member #3 bassem.rabil
I reproduced this regression issue with the old change screen with Gerrit 2.8.1, it seems to me the new change screen is consistent where both sections comments/scores are up-to-date. However the old change screen the upper scores section is out dated, while the lower comments section is up-to-date.
Feb 18, 2014
Project Member #4 bassem.rabil
The steps I used to reproduce are:
* Ensure the old change screen is my default change screen
* Open a change in web UI
* launch verify command from command line for this change, i.e.
ssh -p 29418 <gerrit-host> gerrit review -p <project-name> -m \"test comment 111\" --verified +1 --code-review +2 <SHA-1 of the patchset>
*Reload the change web page, the scores section is not updated while the comments section is updated
ssh -p 29418 <gerrit-host> gerrit review -p <project-name> -m \"test comment 222\" --verified -1 --code-review -2 <SHA-1 of the patchset>
*Reload the change web page, the scores section is not updated while the comments section is updated

Feb 18, 2014
Project Member #5 David.Os...@gmail.com
*Reload the change web page

What do you mean exactly by this step?
Feb 18, 2014
Project Member #6 bassem.rabil
Reload browser page, or click on PermaLink.
Feb 18, 2014
Project Member #7 David.Os...@gmail.com
I tried exactly the same steps. The only difference was: i used one label: --code-review and it worked. Both parts of screen was refreshed. I clicked on permalink, end exited from change screen and reopened it again for the same changed. All was there.

Can you try this scenario: change only one label and exit and reopen the change screen? Does it work for you?
Feb 18, 2014
Project Member #8 bassem.rabil
I tried changing only one label, and still the scores section is not updated after browser refresh or clicking permalink. Were you able to reproduce the issue with changing two labels ?

I want to add here that I used the same user to launch command line to set the labels for reviewing the change, i.e. I am expecting a change in this user entry in scores section after modifying the labels.
Feb 18, 2014
Project Member #9 bassem.rabil
After clearing browser cache it started to be refreshed properly for scores section. This works for changing one or two labels. It seems there was something in cache preventing getting up-to-date state of scores section specifically because this worked for Comments section. From our users reports, they had to perform this browser cache clearing multiple times each day to get the correct scores section for their changes.
Feb 18, 2014
Project Member #10 David.Os...@gmail.com
n. p.
Status: Invalid
May 28, 2014
#11 flub...@gmail.com
I can actually reproduce this problem consistently on v2.8.5 while using Apache with a set mod_expires ExpiresDefault to A300.

Steps for repro:
- Visit change view for a change
- Note response headers for the '/changes/<change>/detail' request [1]
- Refresh browser page, note response headers again for '/changes/<change>/detail' [2]
- Attempt to perform a label update (by giving the review a +1 verify)
- Page will return to change view screen, but the label/review information will be outdated

Response headers before page refresh [1]:
HTTP/1.1 200 OK
Date: Thu, 29 May 2014 00:49:48 GMT
Server: hi
Content-Disposition: attachment
x-content-type-options: nosniff
Etag: a78dd3fbfa855486646c9410cbe76093
Expires: Thu, 29 May 2014 00:49:48 GMT
Cache-Control: private, max-age=0, must-revalidate
Content-Encoding: gzip
Content-Type: application/json; charset=UTF-8
Content-Length: 800
Connection: close

Response headers after page refresh (on subsequent requests) [2]:
HTTP/1.1 304 Not Modified
Date: Thu, 29 May 2014 00:50:23 GMT
Server: hi
Connection: close
Expires: Thu, 29 May 2014 00:55:23 GMT
Cache-Control: max-age=300

I'm guessing Gerrit is not populating the Cache-Control header on a page refresh (only on an initial page visit), and as a result the browser starts caching the /detail GET due to apache assigning a default expiration value. We hadn't seen this problem on 2.6, and this seems to be a regression after we updated to 2.8.5. Turning off Apache's default cache expiration setting provides a workaround, but this is not ideal (since we'd like to cache as much as we can for obvious reasons).
May 29, 2014
Project Member #12 David.Os...@gmail.com
(No comment was entered for this change.)
Status: AwaitingInformation
Sign in to add a comment

Powered by Google Project Hosting