My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 247: Internal Server Error when switching history versions
  Back to list
Status:  Released
Owner:  code-rev...@gtempaccount.com
Closed:  Oct 2012


Sign in to add a comment
 
Reported by code-rev...@gtempaccount.com, Sep 24, 2009
Reported by Andrew D. Stadler (Google) <stadler@android.com> on Fri Jul 17 17:22:08 PDT 2009
Source: JIRA GERRIT-248

Trying to review CL 7661:

https://android-git.corp.google.com/g/#patch,sidebyside,7661,5,src/com/android/email/activity/FolderMessageList.java

1.  twist open patch history
2.  note that there were comments in patch set 3, so click to make that the
"old" version

bug:  Code Review - Unexpected Error - Server Error - Internal Server Error

Also, patch history is now greyed out, I have to refresh the page to get it
back again.
Sep 24, 2009
#1 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Sat Jul 18 11:06:08 PDT 2009

This is fallout from when Cedric removed the "no differences" dialog in commit
2fd32f8616bcd6c92d79d68e6f42e3b5cb507eb1.  The server is trying to render a
patch for something which has no differences.  Since there are no differences,
the server has no difference header to format, resuting in a
NullPointerException inside of the server.  We need to handle this case better.
Sep 24, 2009
#2 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Sat Jul 18 11:18:55 PDT 2009

Fixed by https://review.source.android.com/10708
Sep 24, 2009
#3 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Sat Jul 18 11:18:55 PDT 2009

Fixed in version 2.0.17.
Status: Fixed
Sep 25, 2009
#4 code-rev...@gtempaccount.com
(No comment was entered for this change.)
Labels: FixedIn-2.0.17
Oct 21, 2012
#5 sop@google.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting