My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2453: Custom NoBlock labels prevents submitting the change with new change screen
1 person starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  Feb 2014


Sign in to add a comment
 
Project Member Reported by bassem.rabil, Feb 5, 2014
************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version:
2.8

What steps will reproduce the problem?
1. Create a custom label for your project
[label "Custom-Label"]
function = NoBlock
value = -1 Problems with label
value = 0 No Score
value = +1 Label is okay

2. Add Verified +1 and Code Review +2 for a change
3. Add score -1 for this custom label "Custom-Label" to the change 

What is the expected output? What do you see instead?
On the new change screen the submit button disappeared which indicates that the scores of this custom label is blocking submission. From the documentation, here below the description of NoBlock:
"The label is purely informational and values are not considered when determining whether a change is submittable."

For the old change screen the submit button is appearing as expected because it respects the NoBlock function for this custom label.

Please provide any additional information below.
This is reproducible with Chrome, and Firefox.

Feb 7, 2014
Project Member #1 David.Os...@gmail.com
https://gerrit-review.googlesource.com/54400
Status: ChangeUnderReview
Feb 24, 2014
Project Member #2 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: Submitted
Labels: FixedIn-2.8.2
Mar 11, 2014
Project Member #3 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: Released
Mar 29, 2015
#4 igor.lit...@gmail.com
Hi,

I'm having a similar problem in version 2.10: in new screen submit button appears but seems to do nothing, while when switching to old screen submit works fine on the same change. This happens both on projects with and without custom labels.
Mar 30, 2015
#5 igor.lit...@gmail.com
Sorry, this was my fault - I installed a plugin that broke the submit button. After removing it the button works fine.
Sign in to add a comment

Powered by Google Project Hosting