My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2445: Page jumps/scrolls to top when single-clicking side-by-side diff in Chrome
31 people starred this issue and may be notified of changes. Back to list
Status:  New
Owner:  ----


Sign in to add a comment
 
Reported by ethan.sherrie, Jan 31, 2014
Affected Version:
- Gerrit 2.5
- Chrome 32.0.1700.102 (on OS X 10.8.5)

Reproduction steps:
1. Open a patchset in side-by-side view.
2. Scroll down the page a little (requires a large-ish patchset).
2. Single-click on a line of code, as if you're trying to double-click to start commenting on it...

Expected output:
# The line you clicked on will be highlighted with a blue horizontal line.
# The web-page isn't scrolled.

Actual output:
# The web-page is scrolled up so the line of code is off-screen!
# The line you clicked on will be correctly highlighted with a blue horizontal line, but you'll have to scroll down to see that.

Additional info:
* If you're having a hard-time reproducing the issue, try manually expanding "common lines" in your diff.

Work-around(s):
* Click on the line numbers to add comments.
* Clicking "Reply..." or "Done" (in response to someone else's comment) works.
Feb 12, 2014
#2 jki...@gmail.com
This also happens with Chrome 32.0.1700.107 m on Windows7
Feb 21, 2014
#3 kash...@adap.tv
work-around doesn't work. 
Feb 21, 2014
#4 schniede...@gmail.com
It seems to be fixed in Gerrit 2.8.1 with the new change screen. I am able to reproduce it in 2.7, but no longer in 2.8.1.
Feb 22, 2014
#6 christop...@gmail.com
If you step through the changes using 'n' you can then use 'c' to create a comment. This will of course not help you if you want to comment on an unchanged line...
Sign in to add a comment

Powered by Google Project Hosting