My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2440: the --verified option from 'gerrit review' command is missing in 2.8.1
4 people starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  Jan 2014


Sign in to add a comment
 
Reported by jean.kan...@gmail.com, Jan 30, 2014
I use gerrit 2.8.1.
In the documentation, there is a --verified option for the command 'gerrit review'.
When I enter the following command:
ssh -p 29418 jenkins@192.168.0.18 gerrit review --project TestGerrit --code-review 0 2,1

Everything is fine.
But when I enter the following command:
ssh -p 29418 jenkins@192.168.0.18 gerrit review --project TestGerrit --verified 1 --core-review 0 2,1
An error is displayed:
fatal: "--verified" is not a valid option

I think this is why the gerrit / jenkins plugin is hanging ... It still needs to send a --verified option which make the jenkins submission fails.
Jan 30, 2014
Project Member #1 edwin.ke...@gmail.com
Have you configured the verified label on your Gerrit server? [1]
In Gerrit 2.8.1 by default is doesn't exist.

[1] https://gerrit-review.googlesource.com/Documentation/config-labels.html#label_Verified
Jan 31, 2014
#2 jean.kan...@gmail.com
Yes, now it is reactivated and the gerrit jenkins plugin is working again.
But the documentation is not clear about the --verified option.
And a more explicit note should be added on the website.
There is no informations related to this "incompatibility" either on the gerrit website or on the gerrit jenkins plugin website.
Jan 31, 2014
Project Member #3 edwin.ke...@gmail.com
> But the documentation is not clear about the --verified option.
Already done
  https://gerrit-review.googlesource.com/51800

> And a more explicit note should be added on the website.
This is part of the 2.6 release notes:
  https://gerrit-documentation.storage.googleapis.com/ReleaseNotes/ReleaseNotes-2.6.html#_labels
Status: Submitted
Labels: FixedIn-2.9
Jan 31, 2014
#4 jean.kan...@gmail.com
Thanks for the clarification of the doc.
But for the release not, when you install directly the 2.8, there is no informations related to problems with plugins (I also filled a bug report for gerrit / jenkins).
Something more explicit should be added to all the release notes from 2.6 to 2.8.1.

Jan 31, 2014
Project Member #5 edwin.ke...@gmail.com
> when you install directly the 2.8

When you install 2.8 directly you likly read the 2.8 documentation where this is mentioned
  https://gerrit-documentation.storage.googleapis.com/Documentation/2.8/config-labels.html#label_Verified

> Something more explicit should be added to all the release notes from 2.6 to 2.8.1.

No. I agree the warning should be more explicit in the 2.6 release notes, but the release notes of a release should only contain things that changed in that release and not repeat information from earlier releases.
May 16, 2014
Project Member #6 edwin.ke...@gmail.com
 Issue 1963  has been merged into this issue.
Jul 18, 2014
Project Member #7 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting