| Issue 2417: | Prev/Next file list on Changescreen 2 diff view based on BASE, not current patchsets | |
| 1 person starred this issue and may be notified of changes. | Back to list |
Affected Version: 2.8.1 What steps will reproduce the problem? 1. Open a change with several patch sets, which have different files changed in different patch sets ( i.e. later changes undo changes, so less files changed ) 2. Change view to diff from a patch set pair with different file changes from BASE 3. Navigate prev/next files and see confusion in what files you actually navigate between. What is the expected output? What do you see instead? When navigating between files in a review that is currently based upon different patch sets, rather than BASE->PatchSet, files are skipped. It looks like no matter what patch sets you're comparing against, the file listing to determine prev/next files are based on the files changed between BASE and PatchSet, rather than "Selected Patch Set and Current Patch Set".
Jan 22, 2014
Project Member
#2
David.Os...@gmail.com
Status:
AwaitingInformation
Jan 22, 2014
Actually, that review shows the problem VERY well actually. 1) Open the review link [1] 2) Files in change include: Commit Message, .../Gerrit.java 3) Change "diff against" to be "1: 642b9a" 3) Files in change now includes: Commit Message, .../GerritConfig.java, Gerrit.java, GerritConfigProvider.java 4) Click on "Commit Message" to open the review 5) "next file" goes to Gerrit.java and NOT GerritConfig.java as expected from the file listing 6) There is NO "next file" going to GerritConfigProvider.java So - IMHO - *NOT* working as expected.
Jan 27, 2014
(No comment was entered for this change.)
Status:
Submitted
Labels: FixedIn-2.9
Jul 18, 2014
(No comment was entered for this change.)
Status:
Released
|
|
| ► Sign in to add a comment |