My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2403: Cookbook hello revision doesn't popup a dialog
1 person starred this issue and may be notified of changes. Back to list
Status:  Invalid
Owner:  ----
Closed:  Jan 2014


Sign in to add a comment
 
Reported by org...@gmail.com, Jan 16, 2014
************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version: 2.8.1

What steps will reproduce the problem?
1. Build the cookbook plugin using buck
2. Install it
3. Click Say Hello for a revision

What is the expected output? What do you see instead?
It should pop a dialog for providing its input.

Instead, a (default?) alert pops up in English.

Jan 16, 2014
Project Member #1 David.Os...@gmail.com
It does work as expected [1].

I assume, that you are using deprecated old change screen.
That's correct JS API doesn't work there.

[1] http://imgur.com/PtZ4Sun
Status: AwaitingInformation
Jan 18, 2014
#2 org...@gmail.com
Did you test it on master or on 2.8?

It doesn't work for me on 2.8 even with the new change screen.
Jan 20, 2014
Project Member #3 David.Os...@gmail.com
Yes i did test it on both 2.8 and master and it works. For 2.8 i have compiled cookbook-plugin from stable-2.8 branch. Can you try with these browsers:

* Firefox
* Chrome
* Safari

and see if it makes any difference? Do you see any Javascript errors on the console?
Jan 20, 2014
#4 org...@gmail.com
Seems to work now. Sorry for the noise.
Jan 21, 2014
Project Member #5 David.Os...@gmail.com
n. p.
Status: Invalid
Sign in to add a comment

Powered by Google Project Hosting