My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 240: Please show # drafts even on the first change
  Back to list
Status:  Released
Owner:  code-rev...@gtempaccount.com
Closed:  Oct 2012


Sign in to add a comment
 
Reported by code-rev...@gtempaccount.com, Sep 24, 2009
Reported by Andrew D. Stadler (Google) <stadler@android.com> on Mon Jul 13 20:47:56 PDT 2009
Source: JIRA GERRIT-241

If you submit a CL a few times and view the patch history, one useful thing is
that you can see the number of comments at each revision.

However, after a single submit, and comments, the Patch History is not
displayed, so you cannot see the number of comments.

Note, I know that you can see the # of comments if you type "f" for the file
viewer, but this isn't necessarily in the workflow if you're just using the
"next file -->" links.  So, not terribly high priority, but it would be nice
to fix this, please.
Sep 24, 2009
#1 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Mon Jul 13 21:57:06 PDT 2009

Wait, you want the History table to be present even if there is only one patch
set, with only Base and that one patch set as valid options?  So that if you
expand it, it stays expanded as you navigate through the files?
Sep 24, 2009
#2 code-rev...@gtempaccount.com
Comment by Andrew D. Stadler (Google) <stadler@android.com> on Mon Jul 13 22:21:31 PDT 2009

Sorry, my "ask" wasn't clear.

What I was missing tonight was simply the notes on # comments.  I needed to
know as I was flipping through files (next, next next) and then stopping where
comments had been made.

Since the # comments is in the patch history, when you hide the patch history,
you lose the # of comments indication.

As far as a solution, I'm totally agnostic...  You could always show the patch
history, or, just find some other way to show # comments, or ...?
Sep 24, 2009
#3 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Sat Jul 18 18:08:30 PDT 2009

Fixed by https://review.source.android.com/10720
Sep 24, 2009
#4 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Sat Jul 18 18:08:30 PDT 2009

Fixed in version 2.0.17.
Status: Fixed
Sep 25, 2009
#5 code-rev...@gtempaccount.com
(No comment was entered for this change.)
Labels: FixedIn-2.0.17
Oct 25, 2012
#6 sop@google.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting