My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2362: ChangeScreen2: quick approve button displayed on non-current patch set
1 person starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  Jan 2014


Sign in to add a comment
 
Project Member Reported by sop@google.com, Dec 20, 2013
Get Diffy to Verified+1 a change.
Select a non-current patch set, e.g. the prior one.
Quick approve Code-Review+2 is visible.

It should be hidden on a non-current patch set. We don't allow voting on non-current patch sets.
Jan 9, 2014
Project Member #1 david.pu...@sonymobile.com
Additionally, should the "Verified +1" line (and any other approvals) be hidden for non-current patch sets?

Jan 9, 2014
Project Member #2 david.pu...@sonymobile.com
https://gerrit-review.googlesource.com/53612
Status: ChangeUnderReview
Jan 10, 2014
Project Member #3 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: Submitted
Labels: -Blocking-2.9 FixedIn-2.9
Jul 18, 2014
Project Member #4 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting