My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2352: Can't see deleted code at bottom of file in new diff UI
1 person starred this issue and may be notified of changes. Back to list
Status:  New
Owner:  ----


Sign in to add a comment
 
Reported by mdemp...@google.com, Dec 17, 2013
Affected Version: 2.8-836-g3a93fa0)

What steps will reproduce the problem?
1. Go to https://gwt-review.googlesource.com/#/c/5781/1/user/src/com/google/gwt/core/client/impl/StackTraceCreator.java
2. Scroll to the very bottom using the scroll bar or pgdn key.
3. On the right half of the screen, you'll see the "splice" method; on the left side, you see that a bunch of code was deleted starting at line 441, but don't see the corresponding splice method that was kept.

What is the expected output? What do you see instead?
I expect if I scroll to the very bottom of the page, I should see the bottom of both the before and after code.

However, in the new UI, it seems like I need to click on the left panel to put the cursor there, and then hold the 'down' arrow key to actually get to the bottom of the left panel, and now I can see that the 'splice' method was actually there originally, and I can finally notice that the code added to 'extractName' originated in the now-deleted 'extractNameFromToString' method.
Dec 17, 2013
#1 mdemp...@google.com
Attached is a screenshot demonstrating how I can't see the bottom of the before file contents, even when fully scrolled to the bottom of the UI.
Screenshot from 2013-12-17 14:11:06.png
172 KB   View   Download
Jun 26, 2014
#2 mani.cha...@gmail.com
Hi,
I just checked  this link on recent master https://gwt-review.googlesource.com/#/c/5781/1/user/src/com/google/gwt/core/client/impl/StackTraceCreator.java and scrolled down to the bottom and the splice method was appearing.
Please see the attached screenshot. The issue doesn't seem to be appearing here.
Can you please explain if the issue is still existing?
screenshot.JPG
196 KB   View   Download
Sign in to add a comment

Powered by Google Project Hosting