| Issue 2348: | New Change Screen Not Working With LDAP Authentication | |
| 19 people starred this issue and may be notified of changes. | Back to list |
Affected Version: 2.8 Steps: 1. Install Gerrit 2.7.1 2. Configure LDAP (active directory) authentication and groups from LDAP 3. Push change for review 4. Migrate from 2.7.1 to 2.8 5. Enable new change screen 6. Open the review created in step 3 7. Open some file for diffing -> Code Review - Error page is displayed with the following message: The page you requested was not found, or you do not have permission to view this page. These steps are what are causing the issue with our installation. With the old change screen I am able to open diff view. The following (anonymized) lines are written to httpd_log: 1.2.3.4 - MyUsername [17/Dec/2013:07:37:40 +0200] "GET /review/changes/7224/revisions/6b1b17f41aad553423b71f13cb79b778fdfadd3b/files?reviewed HTTP/1.0" 200 74 "https://my.domain.example.com/review/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36" 1.2.3.4 - MyUsername [17/Dec/2013:07:37:40 +0200] "GET /review/changes/7224/revisions/6b1b17f41aad553423b71f13cb79b778fdfadd3b/comments HTTP/1.0" 200 28 "https://my.domain.example.com/review/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36" 1.2.3.4 - MyUsername [17/Dec/2013:07:37:40 +0200] "GET /review/changes/7224/revisions/6b1b17f41aad553423b71f13cb79b778fdfadd3b/files/path/to/myfile.hpp/diff?context=ALL&intraline HTTP/1.0" 404 10 "https://my.domain.example.com/review/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36" 1.2.3.4 - MyUsername [17/Dec/2013:07:37:40 +0200] "GET /review/changes/7224/detail?O=4 HTTP/1.0" 304 - "https://my.domain.example.com/review/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36" 1.2.3.4 - MyUsername [17/Dec/2013:07:37:40 +0200] "GET /review/changes/7224/revisions/6b1b17f41aad553423b71f13cb79b778fdfadd3b/drafts HTTP/1.0" 200 28 "https://my.domain.example.com/review/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36" We have also OpenID based gerrit installation in use and there everything works after 2.7.1 -> 2.8 upgrade so therefore I think the issue has something to do with LDAP authentication. I also tried the new change view after multiple refresh and with browser that had no browsing history.
Dec 17, 2013
#1
clemme.m...@gmail.com
Jan 7, 2014
Some more details about the issue. If I turn the Diff View (New Change Screen) option to Unified Diff then diff view seems to work -- at least all the files I tried. If the option is turned back to Side by Side while unified diff view is open on different browser window and the diff view is reloaded the error appears. I am, in fact, able to look some of the diffs even with Side by Side but I have not determined which are the conditions that trigger the error. The successfull Side by Side diffs are from other project but that project is also created before the migration to Gerrit 2.8 was made. I included logs from three requests below. Side by Side Error and Unified Success are from the same change and from the same file. Side by Side Success is from other commit (and other project). When comparing the failed and succesfull side by side case the requests are done in different order (at least the request .../revision/2/files?reviewed is done at different time). Side by Side Error: 1.2.3.4 - MyUsername [08/Jan/2014:07:14:56 +0200] "GET /review/ HTTP/1.0" 200 1904 "https://example.com/review/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36" 1.2.3.4 - MyUsername [08/Jan/2014:07:14:56 +0200] "GET /review/gerrit_ui/gwt/chrome/1BEB1F98F392A12232A754A0784B49A8.cache.css HTTP/1.0" 304 - "https://example.com/review/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36" 1.2.3.4 - MyUsername [08/Jan/2014:07:14:56 +0200] "GET /review/accounts/self/capabilities?q=createProject&q=createGroup&q=administrateServer HTTP/1.0" 200 75 "https://example.com/review/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36" 1.2.3.4 - MyUsername [08/Jan/2014:07:14:56 +0200] "GET /review/accounts/self/avatar?s=100 HTTP/1.0" 404 10 "https://example.com/review/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36" 1.2.3.4 - MyUsername [08/Jan/2014:07:14:56 +0200] "GET /review/accounts/self/avatar?s=26 HTTP/1.0" 404 10 "https://example.com/review/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36" 1.2.3.4 - MyUsername [08/Jan/2014:07:14:56 +0200] "GET /review/config/server/top-menus HTTP/1.0" 200 28 "https://example.com/review/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36" 1.2.3.4 - MyUsername [08/Jan/2014:07:14:56 +0200] "GET /review/gerrit_ui/deferredjs/F295C5B1EC66DDBFD2ABD29C02F8DF92/4.cache.js HTTP/1.0" 304 - "https://example.com/review/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36" 1.2.3.4 - MyUsername [08/Jan/2014:07:14:56 +0200] "GET /review/changes/16848/revisions/2/files/path/to/file.cpp/diff?context=ALL&intraline HTTP/1.0" 404 10 "https://example.com/review/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36" 1.2.3.4 - MyUsername [08/Jan/2014:07:14:56 +0200] "GET /review/changes/16848/revisions/2/drafts HTTP/1.0" 200 28 "https://example.com/review/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36" 1.2.3.4 - MyUsername [08/Jan/2014:07:14:56 +0200] "GET /review/changes/16848/detail?O=4 HTTP/1.0" 304 - "https://example.com/review/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36" 1.2.3.4 - MyUsername [08/Jan/2014:07:14:56 +0200] "GET /review/changes/16848 HTTP/1.0" 304 - "https://example.com/review/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36" 1.2.3.4 - MyUsername [08/Jan/2014:07:14:56 +0200] "GET /review/changes/16848/revisions/2/comments HTTP/1.0" 200 28 "https://example.com/review/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36" 1.2.3.4 - MyUsername [08/Jan/2014:07:14:56 +0200] "GET /review/changes/16848/revisions/2/files?reviewed HTTP/1.0" 200 28 "https://example.com/review/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36" 1.2.3.4 - MyUsername [08/Jan/2014:07:14:56 +0200] "GET /review/projects/project/config HTTP/1.0" 200 251 "https://example.com/review/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36" Unified Success: 1.2.3.4 - MyUsername [08/Jan/2014:07:15:06 +0200] "GET /review/ HTTP/1.0" 200 1905 "https://example.com/review/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36" 1.2.3.4 - MyUsername [08/Jan/2014:07:15:06 +0200] "GET /review/gerrit_ui/gwt/chrome/1BEB1F98F392A12232A754A0784B49A8.cache.css HTTP/1.0" 304 - "https://example.com/review/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36" 1.2.3.4 - MyUsername [08/Jan/2014:07:15:06 +0200] "GET /review/accounts/self/capabilities?q=createProject&q=createGroup&q=administrateServer HTTP/1.0" 200 75 "https://example.com/review/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36" 1.2.3.4 - MyUsername [08/Jan/2014:07:15:06 +0200] "GET /review/accounts/self/avatar?s=100 HTTP/1.0" 404 10 "https://example.com/review/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36" 1.2.3.4 - MyUsername [08/Jan/2014:07:15:06 +0200] "GET /review/accounts/self/avatar?s=26 HTTP/1.0" 404 10 "https://example.com/review/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36" 1.2.3.4 - MyUsername [08/Jan/2014:07:15:06 +0200] "GET /review/config/server/top-menus HTTP/1.0" 200 28 "https://example.com/review/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36" 1.2.3.4 - MyUsername [08/Jan/2014:07:15:06 +0200] "GET /review/gerrit_ui/deferredjs/F295C5B1EC66DDBFD2ABD29C02F8DF92/4.cache.js HTTP/1.0" 304 - "https://example.com/review/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36" 1.2.3.4 - MyUsername [08/Jan/2014:07:15:07 +0200] "POST /review/gerrit_ui/rpc/ChangeDetailService HTTP/1.0" 200 680 "https://example.com/review/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36" 1.2.3.4 - MyUsername [08/Jan/2014:07:15:07 +0200] "GET /review/projects/project/config HTTP/1.0" 200 251 "https://example.com/review/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36" 1.2.3.4 - MyUsername [08/Jan/2014:07:15:07 +0200] "POST /review/gerrit_ui/rpc/PatchDetailService HTTP/1.0" 200 3169 "https://example.com/review/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36" 1.2.3.4 - MyUsername [08/Jan/2014:07:15:07 +0200] "PUT /review/changes/16848/revisions/2/files/path/to/file.cpp/reviewed HTTP/1.0" 404 10 "https://example.com/review/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36" Side by Side Success: 1.2.3.4 - MyUsername [08/Jan/2014:07:21:00 +0200] "GET /review/ HTTP/1.0" 200 1904 "https://example.com/review/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36" 1.2.3.4 - MyUsername [08/Jan/2014:07:21:00 +0200] "GET /review/gerrit_ui/gwt/chrome/1BEB1F98F392A12232A754A0784B49A8.cache.css HTTP/1.0" 304 - "https://example.com/review/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36" 1.2.3.4 - MyUsername [08/Jan/2014:07:21:00 +0200] "GET /review/accounts/self/capabilities?q=createProject&q=createGroup&q=administrateServer HTTP/1.0" 200 75 "https://example.com/review/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36" 1.2.3.4 - MyUsername [08/Jan/2014:07:21:00 +0200] "GET /review/accounts/self/avatar?s=100 HTTP/1.0" 404 10 "https://example.com/review/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36" 1.2.3.4 - MyUsername [08/Jan/2014:07:21:00 +0200] "GET /review/accounts/self/avatar?s=26 HTTP/1.0" 404 10 "https://example.com/review/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36" 1.2.3.4 - MyUsername [08/Jan/2014:07:21:00 +0200] "GET /review/config/server/top-menus HTTP/1.0" 200 28 "https://example.com/review/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36" 1.2.3.4 - MyUsername [08/Jan/2014:07:21:00 +0200] "GET /review/gerrit_ui/deferredjs/F295C5B1EC66DDBFD2ABD29C02F8DF92/4.cache.js HTTP/1.0" 304 - "https://example.com/review/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36" 1.2.3.4 - MyUsername [08/Jan/2014:07:21:00 +0200] "GET /review/changes/16472/revisions/2/files?reviewed HTTP/1.0" 200 40 "https://example.com/review/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36" 1.2.3.4 - MyUsername [08/Jan/2014:07:21:00 +0200] "GET /review/changes/16472 HTTP/1.0" 200 323 "https://example.com/review/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36" 1.2.3.4 - MyUsername [08/Jan/2014:07:21:00 +0200] "GET /review/changes/16472/revisions/2/files/.gitignore/diff?context=ALL&intraline HTTP/1.0" 200 2405 "https://example.com/review/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36" 1.2.3.4 - MyUsername [08/Jan/2014:07:21:00 +0200] "GET /review/changes/16472/revisions/2/comments HTTP/1.0" 200 28 "https://example.com/review/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36" 1.2.3.4 - MyUsername [08/Jan/2014:07:21:00 +0200] "GET /review/changes/16472/revisions/2/files HTTP/1.0" 200 92 "https://example.com/review/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36" 1.2.3.4 - MyUsername [08/Jan/2014:07:21:00 +0200] "GET /review/changes/16472/revisions/2/drafts HTTP/1.0" 200 28 "https://example.com/review/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36" 1.2.3.4 - MyUsername [08/Jan/2014:07:21:00 +0200] "GET /review/changes/16472/detail?O=4 HTTP/1.0" 304 - "https://example.com/review/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36" 1.2.3.4 - MyUsername [08/Jan/2014:07:21:00 +0200] "GET /review/projects/project2/config HTTP/1.0" 200 282 "https://example.com/review/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36"
Feb 19, 2014
We're also experiencing this with our LDAP setup and the new change screen. Some files can diff, but others can't. Even the commit message can't be diffed in some cases. Appears to be difficult to predict.
Mar 10, 2014
Same issue here since update to 2.8.1 from 2.5.0. It's strange that it would work with unified diff but not side-by-side. Is that possibly just coincidence? We've noticed some similar intermittent authz failures updating project permissions since the upgrade which have nothing to do with diff. We did not have nscd running on the gerrit server. I enabled it today to see if this makes a difference.
Mar 11, 2014
We are seeing this issue as well and I don't believe this is a minor issue.
Apr 8, 2014
I have just seen the same bug atm within my review
May 14, 2014
No response on this? A am affected also, and if the new change screen should be the default in some time we would definitely have a problem upgrading...
May 14, 2014
I briefly tested 2.9rc1 at our site and the change screen appeared, at first glance, to be OK. Is anyone here still experiencing problems with it on 2.9rc1? Thanks
May 19, 2014
Agreed, this looks to be fixed in 2.9-rc1.
May 19, 2014
(No comment was entered for this change.)
Status:
Submitted
Labels: FixedIn-2.9
Jun 6, 2014
Hm, I just tried 2.9-rc2 and I am still affected by this. The error message is still the same, old change screen works. Can I change something in the setup to make it work here? I have double checked: Running gerrit with LDAP authentication on own port works, but running behind a reverse proxy makes the new change screen fail. I have configured gerrit and apache/nginx as described in the docs, but no success. Regards, Sven
Jun 6, 2014
Our gerrit is also behind reverse proxy (HTTPS). Could the actual reason behind this issue be the reverse proxy (i.e. having LDAP authentication does not have effect on this issue) as someone already said that using openid this issue is also visible
Jun 6, 2014
The authentication type shouldn't have an effect on this. This is purely related to the reverse proxy configuration. Make sure that you have it setup according to the latest version of the reverse proxy documentation: https://gerrit-review.googlesource.com/#/c/57681/1/Documentation/config-reverseproxy.txt
Jun 6, 2014
We have gerrit configured to be at https://example.com/review/ using nginx. So in nginx I have the following: location /review/ { proxy_pass http://gerrit.example.com:8080/review/; proxy_set_header X-Forwarded-For $remote_addr; proxy_set_header Host $host; } and in gerrit configuration: [httpd] listenUrl = proxy-https://*:8080/review/ If I remove the trailing / from the three (3) places the issue is still present.
Jul 18, 2014
(No comment was entered for this change.)
Status:
Released
Jul 21, 2014
Bug appears still in 2.9 stable. Must use either old screen or new screen with default setting "Unified screen". I have my gerrit behind a nginx server with proxy_pass and SSL connection. For authentication I use SSL.
Jul 21, 2014
See Documentation/config-reverseproxy.txt: Make sure to use a 'proxy_pass' URL without any path (esp. no trailing '/' after the 'host:port').
Jul 28, 2014
Thanks, worked!
Nov 11, 2014
Adding "AllowEncodedSlashes On" got this working for me!
Jan 2, 2015
I was also having this issue (with Gerrit 2.9.3), because I left out "nocanon" at the end of the ProxyPass line. My setup is also gerrit behind an Apache HTTPS reverse proxy, with listenUrl = proxy-https://127.0.0.1:6080/ and ProxyPass / http://127.0.0.1:6080/ nocanon However, even after I added "nocanon", the Commit Message is an empty Side by Side diff when there is only 1 patch set.
Jan 2, 2015
It appears like the empty Commit Message was due to caching (of older Gerrit content) in the browser. I've also upgraded to Gerrit 2.10-rc1 when I saw thats being used by gerrit-review.googlesource.com. |
|
| ► Sign in to add a comment |