My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2339: No warning/error on failure to label
1 person starred this issue and may be notified of changes. Back to list
Status:  New
Owner:  ----


Sign in to add a comment
 
Reported by r.d.f.ch...@gmail.com, Dec 12, 2013
************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version: 2.8

What steps will reproduce the problem?
1. Call `gerrit review --label foo=+1 --message test ...` without actual permissions to set the label
2.
3.

What is the expected output? What do you see instead?
Command exits cleanly with no stdout/err and posts message; but label is not changed.
Command should fail (exit with non-zero status and not post message) or at least warn that you do not have permissions.

Please provide any additional information below.

Possibly related: the `--force-message` in allowed previous versions of gerrit quietly vanished and is no longer accepted in this version (it appears it now does this by default anyway...). 

Dec 12, 2013
Project Member #1 edwin.ke...@gmail.com
At least this behaviour is documented by now:
  https://gerrit-review.googlesource.com/51810
Sign in to add a comment

Powered by Google Project Hosting