My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2304: Deleted file presents broken "download" link on left-hand side-by-side
2 people starred this issue and may be notified of changes. Back to list
Status:  New
Owner:  ----


Sign in to add a comment
 
Project Member Reported by dougk....@gmail.com, Dec 3, 2013
Affected Version: 2.7.0

What steps will reproduce the problem?
1. Create review with a deleted file.
2. View file in side-by-side diff view
3. Click "Download" Link on left hand side header

What is the expected output? What do you see instead?
Should either download the old file, or not show the "download" link to begin with.  Instead, a 404 error is returned to the user.

Dec 9, 2013
Project Member #1 dougk....@gmail.com
FYI, this could be resolved as fixed-in 2.8.
Dec 9, 2013
Project Member #2 bklarson@gmail.com
(No comment was entered for this change.)
Status: Released
Labels: FixedIn-2.8
Feb 14, 2014
Project Member #3 dougk....@gmail.com
Hmm, not sure I want to reopen this, but if the commit is a merge commit, I can still reproduce this in 2.8...Maybe that's why I couldn't reproduce it before.
Feb 14, 2014
Project Member #4 bklarson@gmail.com
Re-opening at Doug's request
Status: New
Labels: -FixedIn-2.8
Jul 17, 2014
Project Member #5 david.pu...@sonymobile.com
Was this fixed with  issue 2538  ?

Sep 30, 2014
Project Member #6 dougk....@gmail.com
Does not appear to be; I just reproduced it against 2.9.1.
Sign in to add a comment

Powered by Google Project Hosting