My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2279: ChangeScreen2: Parent commit is missing
5 people starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  Sep 2014


Sign in to add a comment
 
Reported by org...@gmail.com, Nov 25, 2013
Affected Version: 2.8

What is the expected output? What do you see instead?
Parent commit should be displayed. It isn't.
Nov 25, 2013
Project Member #1 edwin.ke...@gmail.com
It is shown under 'Related Changes', isn't it?
Nov 25, 2013
Project Member #2 edwin.ke...@gmail.com
if not it might be  issue 2073 
Nov 25, 2013
#3 org...@gmail.com
No. I mean changes that have no dependencies, based on some commit that is already submitted.
Nov 25, 2013
Project Member #4 edwin.ke...@gmail.com
Ok, I see.
Jan 27, 2014
#5 Mark.J.A...@gmail.com
Being able to see what the parent commit is, even if that commit is already merged, and browse to it via link is useful to know whether a rebase is needed before review makes sense. Also useful for seeing whether a new patch changed the base or not.
May 16, 2014
Project Member #6 edwin.ke...@gmail.com
With 2.9 parent commits are now shown for merge commits:
  https://gerrit-review.googlesource.com/57154
May 16, 2014
#7 Mark.J.A...@gmail.com
That's great also.

But the feature I was looking for was to always have the parent information available for all commits, merge or not, whether the parent is submitted or not. The parent hash, one-line commit message and link was available in the old-style Gerrit UI. People sometimes work on an old head and upload and in the new-style Gerrit UI, there is no way to know anything about the parent, unless (say) the related-changes widget is triggered. So now a reviewer can't know the development context for the patch, or why CI might be failing because the reference results are newer than the patch's parents, etc. This blocks me from using the new UI, which has many nice features.
May 16, 2014
Project Member #8 edwin.ke...@gmail.com
> But the feature I was looking for was to always have the parent information 
> available for all commits, merge or not, whether the parent is submitted or not.

Yes, I understood this and this is why this issue is still open.
May 16, 2014
#9 Mark.J.A...@gmail.com
OK great.
Jul 20, 2014
Project Member #12 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: ChangeUnderReview
Sep 11, 2014
Project Member #13 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: Released
Labels: FixedIn-2.9.1
Sep 11, 2014
#14 Mark.J.A...@gmail.com
Thanks! Looking forward to seeing it running somewhere soon!
Sign in to add a comment

Powered by Google Project Hosting