My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2268: ref-update hook does not block merges
3 people starred this issue and may be notified of changes. Back to list
Status:  New
Owner:  ----


Sign in to add a comment
 
Reported by neil.r.l...@gmail.com, Nov 21, 2013
************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version:
2.6.1

What steps will reproduce the problem?
1. Have a change ready for review
2. Create a ref-update hook as follows:
#!/bin/sh
echo The Message
exit 1
3. Submit the change

What is the expected output? What do you see instead?
The change should not merge and the UI should display The Message somehow. Instead the change is merge and the output from the hook is not displayed or logged anywhere.

Please provide any additional information below.
-The ref-update hook does block repo upload and displays the The Message so the change needs to be added before creating the hook.
-We want to create hooks that block submission of changes that don't pass certain fitness tests. We would prefer to allow changes to be uploaded for review (with warnings) even if they aren't correct so that the patches can improve. Only when merging is attempted do the fitness test block.

Sign in to add a comment

Powered by Google Project Hosting