My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2262: SideBySide2: Cannot start an inline comment by double-clicking on a line
2 people starred this issue and may be notified of changes. Back to list
Status:  WontFix
Owner:  ----
Closed:  Nov 2013


Sign in to add a comment
 
Project Member Reported by david.pu...@sonymobile.com, Nov 17, 2013
************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version:2.8-rc2-274-gbfdb200

What steps will reproduce the problem?
1. Open a change in SideBySide2
2. Double-click on a line

Expected that double-clicking on a line opens the comment edit box, like it does in the old change screen. Instead, I now have to click on the line number at the left.


Nov 22, 2013
Project Member #1 david.pu...@sonymobile.com
I now think this behaviour is actually desired.  Double clicking highlights a word, and then when adding a comment with clicking on the line number the comment becomes a "range comment" on the highlighted word.

Status: WontFix
Jan 29, 2014
#2 brandon....@gmail.com
I was also confused by this change in behavior.  Perhaps there could be some affordance to indicate that I can add a comment when highlighting a word?
Jan 29, 2014
Project Member #3 edwin.ke...@gmail.com
> Perhaps there could be some affordance to indicate 
> that I can add a comment when highlighting a word?

This is already done for Gerrit 2.9. As soon as you select something a clickable comment icon appears and it also tells you that you can press 'c' to insert a comment.
Sign in to add a comment

Powered by Google Project Hosting