My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2251: Inline comments in commit message not included in email notification
1 person starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  May 2014


Sign in to add a comment
 
Project Member Reported by david.pu...@sonymobile.com, Nov 10, 2013
************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version: 2.8-rc2-126-g8da6200

What steps will reproduce the problem?

If a reviewer adds inline comments on a change's commit message, the inline comments are not included in the notification mail.

The mail includes a link to the side-by-side and a "Commit Message:" header, but the actual comment is not there.

See attachment for example.

mail-notification.png
39.1 KB   View   Download
Feb 6, 2014
Project Member #1 david.pu...@sonymobile.com
 Issue 2341  has been merged into this issue.
May 16, 2014
Project Member #2 edwin.ke...@gmail.com
Seems to work by now. Can we close this?
May 18, 2014
Project Member #3 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: Submitted
Labels: FixedIn-2.9
Jul 18, 2014
Project Member #4 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: Released
Dec 17, 2015
Project Member #5 david.pu...@sonymobile.com
While running LuceneQueryChangesTest in Eclipse I noticed a lot of stack traces in the console caused by IncorrectObjectTypeException in the CommentSender class.

  com.google.gerrit.server.mail.CommentSender :
  Cannot load /COMMIT_MSG from 318f37f6faeeebe601d9a91a7c98d08a6d3f6c3e in repo
  org.eclipse.jgit.errors.IncorrectObjectTypeException:
  Object 4b825dc642cb6eb9a060e54bf8d69288fbee4904 is not a commit.

Full stack trace:

http://paste.openstack.org/show/482173/

I haven't been able to reproduce it by manually adding comments but looking at the code it would seem that this exception is what prevents inline comments in the commit message from being added to the email.

Sign in to add a comment

Powered by Google Project Hosting