| Issue 2248: | Gerrit UI and REST permit changing the topic on a merged change | |
| 1 person starred this issue and may be notified of changes. | Back to list |
************************************************************ ***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW ***** ***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL ***** ***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC. ***** ***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS! ***** ************************************************************ Affected Version: probably 2.6+, definitely 2.8 What steps will reproduce the problem? 1.Push a patchset to create a new change 2.Review/merge the change 3.Use the UI or REST to change the topic. What is the expected output? What do you see instead? Expected behavior is for the UI to not allow topic manipulation to a closed change, similar to how the commit message edit button does not appear. Expected behavior for REST is probably to return a 409 Conflict with a status message indicating the change is closed. Instead, using the UI or REST in 2.8 allows the topic to be changed for closed changes. Please provide any additional information below. First, this is definitely not a high priority issue. Prior to 2.6, the only way to alter the change topic is to push a new patchset for a change but specify a different topic. Doing this when the destination change is closed results in an error message "(change 12345 closed)". We think that once a change is merged, it should be entirely immutable. As far as how it actually impacts us, we use the topic as a key into an issue tracking system. I'm not sure why at this point we are doing this vs. using trackingid - probably inertia. We put a search link into the issue tracking system for PM to click to bring up the list of gerrit changes for that issue. Having a topic change post-merge will effectively hide the change.
Nov 7, 2013
Project Member
#1
edwin.ke...@gmail.com
Status:
Released
|
|
| ► Sign in to add a comment |