My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2234: mail not sent for merging patch
2 people starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  Dec 2013


Sign in to add a comment
 
Reported by sujith.u...@ansys.com, Nov 1, 2013
************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version: 2.7

What steps will reproduce the problem?
1. I push a new branch for review (new Gerrit line item under /refs/for/*/).
2. I merge this patch to a local branch and push it for merging.
3. The code gets merged and the change is moved to Merged List but I see errors in the log which I will paste below.

What is the expected output? What do you see instead?
I expect an email saying "Change ----- submitted to --" kind of email. But I do not get any email.

Please provide any additional information below.

Here is the error I see in the log. I hope this helps.

[2013-10-31 20:59:52,629] ERROR com.google.gerrit.server.git.ReceiveCommits : Cannot send email for submitted patch set 8436,4
com.google.inject.ProvisionException: Guice provision errors:

1) null returned by binding at com.google.gerrit.server.mail.MergedSender$Factory.create()
 but parameter 1 of com.google.gerrit.server.mail.MergedSender.<init>() is not @Nullable
  while locating com.google.gerrit.server.project.ChangeControl annotated with @com.google.inject.assistedinject.Assisted(value=)
    for parameter 1 at com.google.gerrit.server.mail.MergedSender.<init>(MergedSender.java:41)
  while locating com.google.gerrit.server.mail.MergedSender annotated with interface com.google.inject.assistedinject.Assisted

1 error
        at com.google.inject.internal.InjectorImpl$4.get(InjectorImpl.java:987)
        at com.google.inject.assistedinject.FactoryProvider2.invoke(FactoryProvider2.java:632)
        at $Proxy55.create(Unknown Source)
        at com.google.gerrit.server.git.ReceiveCommits$5.run(ReceiveCommits.java:2278)
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
        at com.google.gerrit.server.util.RequestScopePropagator$5.call(RequestScopePropagator.java:222)
        at com.google.gerrit.server.util.RequestScopePropagator$4.call(RequestScopePropagator.java:201)
        at com.google.gerrit.server.util.ThreadLocalRequestScopePropagator$1.call(ThreadLocalRequestScopePropagator.java:55)
        at com.google.gerrit.server.util.RequestScopePropagator$1.call(RequestScopePropagator.java:98)
        at com.google.gerrit.server.util.RequestScopePropagator$3.run(RequestScopePropagator.java:163)
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
        at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
        at java.util.concurrent.FutureTask.run(FutureTask.java:166)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$101(ScheduledThreadPoolExecutor.java:165)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:266)
        at com.google.gerrit.server.git.WorkQueue$Task.run(WorkQueue.java:337)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
        at java.lang.Thread.run(Thread.java:679)
Dec 26, 2013
#1 sujith.u...@ansys.com
This issue cannot be seen when I upgraded the server from 2.7 to 2.8

So I think this issue can be closed now.
Dec 27, 2013
Project Member #2 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: Released
Labels: FixedIn-2.8
Sign in to add a comment

Powered by Google Project Hosting