My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2211: Bypass of prohibited self-review
1 person starred this issue and may be notified of changes. Back to list
Status:  Invalid
Owner:  ----
Closed:  Oct 2013


Sign in to add a comment
 
Reported by jonatan....@gmail.com, Oct 21, 2013
************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version: Gerrit 2.7

What steps will reproduce the problem?
1. Check out an active change, by another committer, in a project with prohibited self-review.
2. Amend the commit (preferably with some malicious code..) and push for review.
3. Approve your own code.
4. Profit.

What is the expected output? What do you see instead?
The check against self-approval should match against the author of the current patch-set rather than the original author of the change.

Please provide any additional information below.
Oct 22, 2013
#1 jonatan....@gmail.com
Please close, this is a bug in local prolog code. Doh.
Oct 22, 2013
Project Member #2 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: Invalid
Sign in to add a comment

Powered by Google Project Hosting