My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2181: ref-updated event sent for change before new patch created set in the database
3 people starred this issue and may be notified of changes. Back to list
Status:  New
Owner:  ----
Cc:  edwin.ke...@gmail.com


Sign in to add a comment
 
Reported by s.jarano...@gmail.com, Oct 11, 2013
Affected Version: 2.6.1

What steps will reproduce the problem?
1. prepare 2 change for review
2. submit second change
3. use "Rebase Change" button in review

When I click rebase button I see "Internal server".
The patchset dosen't change status.


There is an error in server log:

[2013-10-11 11:23:50,119] WARN  / : Error in rebaseChange
com.google.inject.ProvisionException: Guice provision errors:

1) null returned by binding at com.googlesource.gerrit.plugins.reviewersbyblame.ReviewersByBlame$Factory.create()
 but parameter 9 of com.googlesource.gerrit.plugins.reviewersbyblame.ReviewersByBlame.<init>() is not @Nullable
  while locating com.google.gerrit.reviewdb.client.PatchSet annotated with @com.google.inject.assistedinject.Assisted(value=)
    for parameter 9 at com.googlesource.gerrit.plugins.reviewersbyblame.ReviewersByBlame.<init>(ReviewersByBlame.java:88)
  while locating com.googlesource.gerrit.plugins.reviewersbyblame.ReviewersByBlame annotated with interface com.google.inject.assistedinject.Assisted

1 error
        at com.google.inject.internal.InjectorImpl$4.get(InjectorImpl.java:987)
        at com.google.inject.assistedinject.FactoryProvider2.invoke(FactoryProvider2.java:632)
        at $Proxy136.create(Unknown Source)
        at com.googlesource.gerrit.plugins.reviewersbyblame.RefUpdateListener.onGitReferenceUpdated(RefUpdateListener.java:110)
        at com.google.gerrit.server.extensions.events.GitReferenceUpdated.fire(GitReferenceUpdated.java:55)
        at com.google.gerrit.server.extensions.events.GitReferenceUpdated.fire(GitReferenceUpdated.java:45)
        at com.google.gerrit.server.changedetail.RebaseChange.rebase(RebaseChange.java:347)
        at com.google.gerrit.server.changedetail.RebaseChange.rebase(RebaseChange.java:157)
        at com.google.gerrit.httpd.rpc.changedetail.RebaseChangeHandler.call(RebaseChangeHandler.java:65)
        at com.google.gerrit.httpd.rpc.changedetail.RebaseChangeHandler.call(RebaseChangeHandler.java:37)
        at com.google.gerrit.httpd.rpc.Handler.to(Handler.java:65)
        at com.google.gerrit.httpd.rpc.changedetail.ChangeManageServiceImpl.rebaseChange(ChangeManageServiceImpl.java:45)

Oct 11, 2013
Project Member #1 edwin.ke...@gmail.com
Gerrit should not be affected by an exception in a plugin. This is already fixed by:
  https://gerrit-review.googlesource.com/49727
Oct 11, 2013
Project Member #2 edwin.ke...@gmail.com
The problem is that Gerrit sends the ref-updated event for the change before it creates the new patch set in the database. [1] adds a check for this case in the plugin so that there is at least no exception anymore. 


[1] https://gerrit-review.googlesource.com/50781
Oct 15, 2013
Project Member #3 david.pu...@sonymobile.com
(No comment was entered for this change.)
Summary: ref-updated event sent for change before new patch created set in the database (was: reviewers by blame plugins blocks rebase options from gui)
Oct 31, 2013
Project Member #4 edwin.ke...@gmail.com
 Issue 2090  has been merged into this issue.
Cc: edwin.ke...@gmail.com
Oct 31, 2013
Project Member #5 edwin.ke...@gmail.com
The same problem exists whenever the project.config in refs/meta/config is updated, e.g. if permissions of a project are changed and saved for review.
Sign in to add a comment

Powered by Google Project Hosting