My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2172: Search for -is:abandoned causes Internal Server Error
8 people starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  May 2014


Sign in to add a comment
 
Reported by krinklemail@gmail.com, Oct 8, 2013
Affected Version: 2.7-rc2-505-g7502a46

What steps will reproduce the problem?
1. Search for anything with " -is:abandoned " (without quotes)

What is the expected output? What do you see instead?

A "500 Server Error" response is given to the XHR request for the query.

Both is:abandoned and -is:open work fine. It seems specific to the negated search for abandoned.


--- Request dump ---

GET /r/changes/?q=reviewer:Krinkle+-is:abandoned&n=25&O=1 500 (Server Error)
$doSend cache.html:22785
$sendRequest cache.html:22801
$send cache.html:11726
next_0 cache.html:6021
onLoad_35 cache.html:7554
$onAttach_0 cache.html:2357
onAttach_0 cache.html:2367
$setParent cache.html:336
$setWidget cache.html:674
setWidget cache.html:704
$add cache.html:648
$setView cache.html:2739
display_0 cache.html:2081
$doSearch cache.html:3416
onKeyPress_8 cache.html:3462
dispatch_9 cache.html:22062
dispatch_0 cache.html:12147
$doFire cache.html:22466
$fireEvent_1 cache.html:22379
$fireEvent cache.html:250
fireNativeEvent cache.html:12184
$onBrowserEvent cache.html:279
$onBrowserEvent_1 cache.html:4251
onBrowserEvent_5 cache.html:4296
onBrowserEvent_2 cache.html:2372
dispatchEvent_0 cache.html:25402
(anonymous function) cache.html:25821
apply_2 cache.html:20610
entry0 cache.html:20648
(anonymous function)

Request URL: https://gerrit.wikimedia.org/r/changes/?q=reviewer:Krinkle+-is:abandoned&n=25&O=1
Request Method: GET
Status Code: 500 Server Error

Request Headers:
 GET /r/changes/?q=reviewer:Krinkle+-is:abandoned&n=25&O=1 HTTP/1.1 
 Host: gerrit.wikimedia.org
 Connection: keep-alive
 Cache-Control: no-cache
 Pragma: no-cache
 Accept: application/json
 Referer: https://gerrit.wikimedia.org/r/
 Accept-Encoding: gzip,deflate,sdch
 Accept-Language: en-US,en;q=0.8

Query String:
 q=reviewer:Krinkle+-is:abandoned&n=25&O=1

Response Headers:
 HTTP/1.1 500 Server Error
 Date: Tue, 08 Oct 2013 18:42:31 GMT
 Cache-Control: no-cache, no-store, max-age=0, must-revalidate
 Pragma: no-cache
 Expires: Mon, 01 Jan 1990 00:00:00 GMT
 Content-Type: text/plain;charset=UTF-8
 Vary: Accept-Encoding
 Content-Encoding: gzip
 Content-Length: 42
 Connection: close

Response Body:
1 Internal server error
2 


Oct 8, 2013
Project Member #2 david.pu...@sonymobile.com
Reproducible with latest master.

ERROR com.google.gerrit.httpd.restapi.RestApiServlet : Error in GET /changes/?q=-is:abandoned&n=25&O=1
com.google.gwtorm.server.OrmException: No ChangeDataSource: status:new
	at com.google.gerrit.server.query.change.OrSource.read(OrSource.java:49)
	at com.google.gerrit.server.query.change.AndSource.readImpl(AndSource.java:110)
	at com.google.gerrit.server.query.change.AndSource.read(AndSource.java:94)
	at com.google.gerrit.server.query.change.QueryProcessor.queryChanges(QueryProcessor.java:258)
	at com.google.gerrit.server.query.change.QueryChanges.query0(QueryChanges.java:154)
	at com.google.gerrit.server.query.change.QueryChanges.query(QueryChanges.java:142)
	at com.google.gerrit.server.query.change.QueryChanges.apply(QueryChanges.java:109)
	at com.google.gerrit.server.query.change.QueryChanges.apply(QueryChanges.java:1)
	at com.google.gerrit.httpd.restapi.RestApiServlet.service(RestApiServlet.java:303)

Status: Accepted
Oct 9, 2013
#3 dborowitz@google.com
Haven't investigated, but this sounds similar to the issue I tried to fix here:
https://gerrit-review.googlesource.com/49780

Unfortunately as per that commit message that was a bit of a hack and didn't really fix the underlying problem.
May 16, 2014
Project Member #4 edwin.ke...@gmail.com
Seems to work now.
Status: Submitted
Labels: FixedIn-2.9
Jul 18, 2014
Project Member #5 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting