My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2155: When I view a file of a change, it gets automatically marked as "reviewed"
1 person starred this issue and may be notified of changes. Back to list
Status:  Invalid
Owner:  ----
Closed:  Oct 2013


Sign in to add a comment
 
Reported by roland.i...@gmx.de, Oct 1, 2013
Affected Version: 2.7

What steps will reproduce the problem?
1. View some Change, and choose a file from the list that does not already have the "Reviewed" checkmark.
2. Click on "Unified" for that file.
3. Click on "Up to change"
4. Look at the "Reviewed" column of that file.

What is the expected output? What do you see instead?

I expect that there is no checkmark. But there is one, although I never clicked on any "Reviewed" button or checkbox.

Oct 1, 2013
Project Member #1 edwin.ke...@gmail.com
If you don't want that the reviewed flag is set automatically on viewing a file, enable "Manual Review" in your users diff preferences.
Status: Invalid
Oct 1, 2013
#2 roland.i...@gmx.de
Ah, I missed that setting. I had expected it in the global settings dialog. It's a surprise that I can only change the settings when I am in diff mode. What if I don't have a change at the moment => does that mean I couldn't change my settings?

A second point is that the "Up to change" still does not imply a "mark as reviewed" to me. The navigation clearly distinguishes between "Reviewed and Next" and "Next", which I find very useful. The only exception to me seems to be the "Up to change" link, which in its current form should better be labelled "Mark as reviewed and up to change".

I want to keep my "Manual Review" setting set to "true", like it is now. I just don't want the "Up to change" link to mark the file as reviewed.
Sign in to add a comment

Powered by Google Project Hosting