My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 213: N and P don't always go to changes on side-by-side diff view
  Back to list
Status:  Released
Owner:  code-rev...@gtempaccount.com
Closed:  Oct 2012


Sign in to add a comment
 
Reported by code-rev...@gtempaccount.com, Sep 24, 2009
Reported by Dave Bort <dbort@android.com> on Wed Jun 03 14:17:55 PDT 2009
Source: JIRA GERRIT-213
Affected Version: 2.0.13.1
Environment: Firefox 3.0.10 on Hardy (also seen in Chrome on other platforms)

On some side-by-side diff views, pressing N and P will jump to the beginning
or end of the file without stopping at the changes.  Doesn't always happen
though.

Here's one: https://review.source.android.com/Gerrit#patch,sidebyside,10206,3,arch/arm/mach-msm/include/mach/camera.h

In this case, there's only a deletion, but I'm pretty sure I've seen it happen
on diffs with additions.  Maybe those only had additions, with no changes/
deletions?
Sep 24, 2009
#1 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Wed Jun 03 14:21:57 PDT 2009

I think we've narrowed it down to it happens only on files with exactly one
hunk in them.

ctate reported it too last Friday, but failed to open a bug for it.  :-)
Sep 24, 2009
#2 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Wed Jun 03 16:51:49 PDT 2009

Fixed by https://review.source.android.com/10259
Sep 24, 2009
#3 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Wed Jun 03 16:51:49 PDT 2009

Fixed in version 2.0.14.
Status: Fixed
Sep 25, 2009
#4 code-rev...@gtempaccount.com
(No comment was entered for this change.)
Labels: FixedIn-2.0.14
Oct 25, 2012
#5 sop@google.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting