| Issue 2122: | Review comments do not show up for unchanged files | |
| 4 people starred this issue and may be notified of changes. | Back to list |
************************************************************ ***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW ***** ***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL ***** ***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC. ***** ***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS! ***** ************************************************************ Affected Version: 2.6.1 What steps will reproduce the problem? 1. Leave a review comment on a file, such as "Fix this at once." 2. Answer the comment with "No, it must be kept like this." 3. Upload a new patch set, but do not change the file in which the comment is. 4. Do a side-by-side diff on the file between the two patch sets. What is the expected output? What do you see instead? The expected output is that I see the file, and my comment, and its answer, even though the file was not changed. This has worked previously. But now, instead, I see nothing at all in the diff. If I have left comments on several other files, there's a great risk that I won't notice that this comment has been ignored for one reason or another. Please provide any additional information below.
Sep 13, 2013
Project Member
#1
bklarson@gmail.com
Sep 13, 2013
I am pretty sure it has. I review quite a lot of code every day, and what I normally do is to have patchset n and n+1 in a side-by-side view. Then I can see what my comments were, what the answer was, and what changes have been applied between the two patchsets to fix whatever the problem was. This still works fine, _except_ if there were no changes made in the file, because then there is no diff. Previously, the n and n+1 version of the file were showing, of course they had no differences, but at least my comment and its answer were showing (and 10 lines of context). Now there's nothing.
Sep 13, 2013
Oh - I see, yes if you are diffing between patchsets that should work. Sorry for my confusion, I thought you were diffing against base.
Sep 17, 2013
Issue 2123 has been merged into this issue.
Oct 11, 2013
https://gerrit-review.googlesource.com/#/c/50751/
Oct 11, 2013
(No comment was entered for this change.)
Status:
Submitted
Oct 11, 2013
(No comment was entered for this change.)
Labels:
FixedIn-2.6.2
Dec 9, 2013
(No comment was entered for this change.)
Labels:
-FixedIn-2.6.2 FixedIn-2.8
Dec 9, 2013
(No comment was entered for this change.)
Status:
Released
Sep 16, 2015
thank you information sir http://www.taspriaonline.com/ |
|
| ► Sign in to add a comment |