My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 210: Report an error if ssh_host_key can't be written
  Back to list
Status:  Released
Owner:  code-rev...@gtempaccount.com
Closed:  Oct 2012


Sign in to add a comment
 
Reported by code-rev...@gtempaccount.com, Sep 24, 2009
Reported by Shawn Pearce <sop@google.com> on Fri May 29 13:17:04 PDT 2009
Source: JIRA GERRIT-210
Affected Version: 2.0.13

MINA SSHD doesn't report a failure if the Java serialized object version of
the host key can't be written to disk.  This code path is used when
BouncyCastle Crypto isn't available and GerritSshDaemon chooses to create
ssh_host_key.

If the daemon can't write the file, it fails silently, but then generates a
new host key on next startup, which confuses every client out there, and
reduces security, since they can't trust the host key anymore.
Sep 24, 2009
#1 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Fri May 29 13:17:48 PDT 2009

A simple work around might just be to look for the host key file after
startup, it should be there, if its not, we failed to write it.
Sep 24, 2009
#2 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Sat May 30 14:03:56 PDT 2009

Fixed by https://review.source.android.com/10164
Sep 24, 2009
#3 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Sat May 30 14:03:56 PDT 2009

Fixed in version 2.0.13.
Status: Fixed
Sep 25, 2009
#4 code-rev...@gtempaccount.com
(No comment was entered for this change.)
Labels: FixedIn-2.0.13
Oct 25, 2012
#5 sop@google.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting