My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 209: Please add line wrapping to long comments on the main comment screen
1 person starred this issue and may be notified of changes. Back to list
Status:  WontFix
Owner:  code-rev...@gtempaccount.com
Closed:  Sep 2009


Sign in to add a comment
 
Reported by code-rev...@gtempaccount.com, Sep 24, 2009
Reported by Andrew D. Stadler (Google) <stadler@android.com> on Fri May 29 11:50:39 PDT 2009
Source: JIRA GERRIT-209

See https://android-git.corp.google.com/g/Gerrit#change,2685

The long description requires horizontal scrolling to read.  Can you put these
in a box so they wrap to the window width?
Sep 24, 2009
#1 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Fri May 29 13:08:09 PDT 2009

No.

Existing git tools do not line wrap messages.  Try to view this change in
gitk, git log, git format-patch, any of them is going to produce the same
horrible effect.

Authors must line wrap their commit messages using hard carriage returns, so
that all tools line wrap correctly.
Sep 24, 2009
#2 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Fri May 29 13:08:09 PDT 2009
Status: WontFix
Sep 24, 2009
#3 code-rev...@gtempaccount.com
Comment by Christopher Tate <ctate@google.com> on Tue Jun 09 13:07:30 PDT 2009

We should make 'repo upload' refuse to handle commits with changes more than
80 cols, then.  As it stands now, people are making submissions to the code
base that have change titles that are truncated even on 30" monitors.
Sign in to add a comment

Powered by Google Project Hosting