My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2065: ChangeScreen2: Make ChangeScreen2 the default change screen
2 people starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  Mar 2014


Sign in to add a comment
 
Project Member Reported by edwin.ke...@gmail.com, Aug 20, 2013
The change screen is completely redesigned and rewritten as ChangeScreen2. At the moment it is available by modifying the change screen URL to be /#/c2/... instead of /#/c/...

The new change screen should become the default change screen once it supports all important features of the old change screen.
Aug 20, 2013
Project Member #1 edwin.ke...@gmail.com
(No comment was entered for this change.)
Blockedon: gerrit:2066
Aug 20, 2013
Project Member #2 edwin.ke...@gmail.com
(No comment was entered for this change.)
Blockedon: gerrit:2067
Aug 21, 2013
Project Member #3 edwin.ke...@gmail.com
(No comment was entered for this change.)
Blockedon: gerrit:2069
Aug 21, 2013
Project Member #4 edwin.ke...@gmail.com
Features which are intentionally removed with ChangeScreen2:

* 'Expand Recent' for expanding the recent summary comments is removed.
Edwin: "Personally I don't need this feature."
Shawn: "I agree. I tried hard to have the comments mostly fit collapsed."

* The 'Publish and submit' button to publish and submit with a single click is removed.
Instead we may have a convinient submit button in the header (similar as we already have "Code-Review+2' there).
Shawn:
"Two click on exactly the same pixels might be a problem, the user
might submit by mistake. But we could move submit to the header row. I
kind of prefer where it is as a short mouse drag down to the left
taking a bit more intent to submit."
David Pursehouse:
"In the past there has been confusion about the meaning of "publish and submit".  I am in favour of keeping the submit action separate from the publish comments/approval action."

* The links to open all diffs each in an own tabs are removed.
Edwin: "I never used this functionality and it's probably no big deal to remove it."
Shawn: "It also doesn't always work. Its notably broken in Chrome right now,
with no fix in sight."
Aug 21, 2013
Project Member #5 David.Os...@gmail.com
* The links to open all diffs each in an own tabs are removed.

Please don't event try to restore that feature again. It doesn't make any sense (even if it would work).
Aug 28, 2013
#6 sop@google.com
(No comment was entered for this change.)
Blockedon: gerrit:2092
Sep 5, 2013
Project Member #7 edwin.ke...@gmail.com
(No comment was entered for this change.)
Blockedon: gerrit:2108
Sep 10, 2013
Project Member #8 edwin.ke...@gmail.com
(No comment was entered for this change.)
Blockedon: gerrit:2116
Sep 27, 2013
Project Member #9 edwin.ke...@gmail.com
(No comment was entered for this change.)
Blockedon: gerrit:2146
Sep 30, 2013
#10 sop@google.com
(No comment was entered for this change.)
Blockedon: gerrit:2073 gerrit:2151
Mar 17, 2014
Project Member #11 jrn@google.com
https://gerrit-review.googlesource.com/51555
Status: Submitted
Labels: FixedIn-2.9
Jul 18, 2014
Project Member #12 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting