My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2044: regression: "change-merge" event missing for changes with annotated tag attached in 2.6 / 2.7
1 person starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  Sep 2013


Sign in to add a comment
 
Reported by lva...@gmail.com, Aug 2, 2013
Affected Version: 2.6.x, 2.7-rc3 

What steps will reproduce the problem?
0. start monitoring via ssh gerrithost gerrit stream-event
1. in any repository create commit: git commit -a -m "message" somefile
2. Attach annotated tag to it: git tag -a -m "tag message" sometag
3. push for review: git push origin master:refs/for/master --tags
4. go to UI, do review and merge of that change.
5. notice that in stream-event it would be no "change-merged" event. it would be only "comment-added" and "ref-updated" events for that repository.


What is the expected output? What do you see instead?
Expected that "change-merged" event would be generated (like it was in 2.5.x until code in MergeOp.java was refactored in 2.6.x branch). Ideally would be also good to get once again ref-update event for that tag once it's merged.
Observed: no "change-merged" event for changes that have annotated tag attached. It was present in 2.4.x/2.5.x

Please provide any additional information below.

I suspect something wrong in logic in gerrit-server/src/main/java/com/google/gerrit/server/git/MergeOp.java

Aug 13, 2013
Project Member #3 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: ChangeUnderReview
Sep 18, 2013
Project Member #4 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: Submitted
Labels: FixedIn-2.7
Sep 20, 2013
Project Member #5 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting