My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2007: Wrong behaviour of Gerrit, if Push for review into wrong branch (ref/for)
1 person starred this issue and may be notified of changes. Back to list
Status:  New
Owner:  ----


Sign in to add a comment
 
Reported by presich....@gmail.com, Jul 12, 2013
Affected Version: 2.5.1

What steps will reproduce the problem?
1. Allow Create reference permissions under refs/heads/*
2. Push commit to the wrong review branch: ref/for/master (not REFS but REF)

What is the expected output?

1. Branch ref/for/master should be created
2. patchset-created hook should get ref/for/master as branch parameter
3. As I understand, change should not be created at all, right?
4. if reply to item 3 - not, than UI should show ref/for/master as branch, where change has been pushed to

What do you see instead?

1. Branch ref/for/master should is created, BUT:
2. patchset-created hook got master as branch parameter
3. UI show master as branch, where change has been pushed to
4. Change is created on UI and automatically merged into the repository with comment: Change has been successfully pushed into branch ref/for/feature/decomposition.

As a workaround we are going to deny any rights to ref/for refspec.

Sign in to add a comment

Powered by Google Project Hosting