| Issue 2: | Limit fetch/clone through internal sshd when git:// is available | |
| Back to list |
Reported by Shawn Pearce <sop@google.com> on Wed Jan 07 16:03:42 PST 2009 Source: JIRA GERRIT-2 Affected Version: 2.0 The internal sshd and git upload-pack implementations aren't nearly as efficient as the native C git daemon is. Serving a full repository over the sshd is very CPU intensive and takes longer than serving that same repository over git:// using the native C implementation. If the project is available over git:// through the native C daemon (meaning its access isn't restricted) we should encourage users to use that port whenever possible by denying large fetch requests made through the ssd port. This likely requires inserting a limiter into JGit's UploadPack implementation, where we can abort the "counting" phase of the ObjectWriter if more than X objects are included in the result set. This way small incremental fetches can be done over the ssh port, as its more convenient to the user to have one URL they common fetch/push through, but larger ones can be aborted to save server resources.
Sep 24, 2009
#1
code-rev...@gtempaccount.com
Sep 24, 2009
(No comment was entered for this change.)
Status:
Accepted
Owner: --- Labels: -Priority-Major -Type-Bug Priority-Minor Type-Feature
Dec 17, 2009
git-upload-pack performance through Gerrit is actually fairly efficient these days, especially in 2.1 and later, and we're only trying to make it faster. There's no point in blocking a user from cloning from us.
Status:
WontFix
Labels: FixedIn-2.1 |
|
| ► Sign in to add a comment |