My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 1992: 'Edit Topic' comment action is not treated as an event
1 person starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  Jul 2013


Sign in to add a comment
 
Reported by saxo...@gmail.com, Jul 3, 2013
************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version: 2.6.x

What steps will reproduce the problem?
1.Create a new change
2.Use the UI to modify the topic
3.

What is the expected output? What do you see instead?

When the topic is modified via the UI the result is saved as a comment, e.g. "Topic updated from X to Y". I expect this to generate a 'comment-added' event in the event stream and trigger the comment-added hook. This is not happening.

Please provide any additional information below.

This breaks topic-based work tracking integrations using change-merged. We use the topic as a key into other systems, so it has to match specific IDs/patterns.

Developers can now use a valid topic to get past patchset-created/draft-published/ref-update, then change to an invalid topic. Afterwards the only opportunity to catch a bad topic is in comment-added, e.g. after a review. 

If comment-added can't stop a review+submit from executing a merge, then the topic-based work tracking scheme is broken. If a review+submit can be interrupted by comment-added then we're OK, although 'fixing' a problem would require another review.
Jul 7, 2013
Project Member #1 david.pu...@sonymobile.com
I'm not sure if this should generate a "comment-added" event, or if there should be a new event type like "topic-changed" or "topic-edited".

Jul 7, 2013
#2 saxo...@gmail.com
Either way is fine, although it looked to us like it would be easier to use the existing comment-added event - changing the topic does generate a comment - vs. creating a whole new event + hook. We definitely want to be able to have a hook run after the event.
Jul 11, 2013
Project Member #3 david.pu...@sonymobile.com
https://gerrit-review.googlesource.com/#/c/47798/
Status: ChangeUnderReview
Jul 12, 2013
Project Member #4 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: Submitted
Labels: FixedIn-2.8
Dec 9, 2013
Project Member #5 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting