My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 1988: updating a draft change might put parent change in "Half-Draft" mode
1 person starred this issue and may be notified of changes. Back to list
Status:  WontFix
Owner:  ----
Closed:  Jul 2013


Sign in to add a comment
 
Reported by fr...@benkstein.net, Jul 1, 2013
Affected Version: 2.5.2, 2.6-rc1

What steps will reproduce the problem?
1. create a commit and push as a normal change (A)
2. amend said commit
3. create another commit and push as draft change (B)

What is the expected output? What do you see instead?

Step 1 creates a new change (A) as expected.  Step 3 creates a new change (B) as a draft change.  Afterwards, though, A cannot be voted upon normally and cannot be submitted.  Also there are "Publish" and "Delete Draft Patch Set" buttons in the change's page but the Status is still listed as "Review in Progress".  Also, it can be seen normally by other users.

Attached screenshot shows the broken change.
Gerrit-Half-Draft.jpg
48.7 KB   View   Download
Jul 3, 2013
Project Member #1 edwin.ke...@gmail.com
I would say this is the expected behaviour.

Please note that you can do both, push a new commit as draft change and push an amended commit as a draft patch set to an existing change. Both is done by pushing to refs/drafts/.

If you push an amended commit as a draft patch set to an existing change, then this draft patch set can be published or deleted by clicking on the corresponding buttons. Both draft changes and draft patchsets are only visible to the change owner AND all the reviewers of the change.
Status: WontFix
Sign in to add a comment

Powered by Google Project Hosting