| Issue 1984: | Left-side of side-by-side review for image review is broken | |
| 8 people starred this issue and may be notified of changes. | Back to list |
************************************************************ ***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW ***** ***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL ***** ***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC. ***** ***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS! ***** ************************************************************ Affected Version: 2.7-rc2-505-g7502a46 What steps will reproduce the problem? 1. A commit that touches an image (e.g. rename the image). 2. View it side-by-side 3. Observe What is the expected behaviour? See the old image on the left and the new on the right. Perhaps optimised to show only 1 image if binary files do not differ. What do you see instead? I see two (attempted to be) displayed images (two img tags). The left one leads to Not Found, the second displays the image correctly. Please provide any additional information below. Summary of diff: diff --git a/lib/resources/images/tipsy.png b/repo/resources/images/tipsy.png similarity index 100% rename from lib/resources/images/tipsy.png rename to repo/resources/images/tipsy.png Binary files differ img[src] of left side: https://gerrit.wikimedia.org/r/cat/70115%2C6%2Crepo/resources/images/tipsy.png%5E1 Leads to "Not Found" img[src] of right side: https://gerrit.wikimedia.org/r/cat/70115%2C6%2Crepo/resources/images/tipsy.png%5E0 Leads to image in question.
Jun 30, 2013
#1
krinklemail@gmail.com
Jul 2, 2013
(No comment was entered for this change.)
Labels:
Blocking-2.7
Jul 16, 2013
This only affects renames, and it appears this code (ca. CatServlet.java:345) hasn't changed in a while. Can you confirm that this is a regression in 2.6?
Jul 16, 2013
Oops, don't know where I got that line number, more like l. 197.
Jul 16, 2013
Confirmed that this bug exists in 2.5.6. Definitely still a bug, but taking it off the Blocking-2.7 list since it's not a regression in 2.6 or 2.7.
Labels:
-Blocking-2.7
|
|
| ► Sign in to add a comment |