| Issue 1980: | Per file "reviewed" column no longer getting ticked off? | |
| 12 people starred this issue and may be notified of changes. | Back to list |
Affected Version: 2.6/2.6.1 After upgrading to 2.6 and 2.6.1 I've noticed that as we go thru files during a review they no longer seem to get ticked off in the 'reviewed' column when looking back at the review. We have noticed that sometimes 1 or 2 files will get ticked off, but as yet we've not noticed any pattern to why some do and the rest don't. What steps will reproduce the problem? 1. Open a review 2. Step thru some files 3. Review to review page What is the expected output? What do you see instead? I expect to see a green tick next to the 'reviewed' column of each file, instead this is blank, altho randomly a file may get ticked.
Jul 3, 2013
#1
sop@google.com
Status:
WontFix
Jul 4, 2013
Can you please explain why you won't fix this issue?
Jul 4, 2013
Have a look at this discussion on the mailing list: https://groups.google.com/d/msg/repo-discuss/ggAOdcZXhiM/_AOzzMus72oJ
Jul 4, 2013
Essentially it came down to missing Apache mod_proxy configuration options: AllowEncodedSlashes On and also "nocanon" being appended to a rule. These were documented in the release notes and documentation, and whilst I had mentioned that to our ops staff it appears as tho it was missed. Personally I'd rather see Gerrit use URLs that didn't need magic settings ( and also not using , in URLs ( that really breaks on some tools recognizing them ) that's a separate issue to this. |
|
| ► Sign in to add a comment |