My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 1965: latest snapshot gerrit doesn't care about canonicalURL and uses tomcat/jetty paths directly
3 people starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  Sep 2013


Sign in to add a comment
 
Reported by Ian.Kuml...@gmail.com, Jun 18, 2013
************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Yes, i know i'm early... ;) but i'd rather we fix this before release :)

Affected Version: v2.7-rc1-529-g34b557c

What steps will reproduce the problem?
1. Set up gerrit with a caching webserver
2. Set set the caching web server to use gerrit-test while gerrit listens to localhost:8080/gerrit
3. Try to log in

What is the expected output? What do you see instead?

Expected: A successful login.

Found: Failure to login, using http://<caching-frontend>/gerrit instead of http://<caching-frontend>/gerrit-test/

Please provide any additional information below.

This looks like a error in:
gerrit-openid/src/main/java/com/google/gerrit/httpd/auth/openid/LoginForm.java line 231.

It gets the root path from tomcat/jetty and doesn't care about the caching frontend. But just changing it here is not the solution, there is some post handler somewhere that is also doing the wrong thing.
(Yes, this is ldap, i think the exact same thing happens in openid)
Sep 3, 2013
#1 Ian.Kuml...@gmail.com
I was surprised to find that this bug still exists in -rc4

My workaround to do some local testing became (nginx):
    location /gerrit/ {
        proxy_pass              http://localhost:8080;
        proxy_set_header        X-Forwarded-For $remote_addr;
        proxy_set_header        Host $host;
    }
    # Bloody workaround
    location /login/ {
        proxy_pass              http://localhost:8080/gerrit/login/;
        proxy_set_header        X-Forwarded-For $remote_addr;
        proxy_set_header        Host $host;
    }
---
Sep 23, 2013
#2 Ian.Kuml...@gmail.com
This was fixed in 2.7-rc5
Sep 23, 2013
Project Member #3 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: Released
Labels: FixedIn-2.7
Sign in to add a comment

Powered by Google Project Hosting