| Issue 1952: | Gerrit 2.6-rc3 cannot show diffs when running in IE in compatibility mode | |
| 6 people starred this issue and may be notified of changes. | Back to list |
The changes to the Gerrit diff for 2.6 cause IE to fail when it's running in 'compatibility mode'. Unfortunately compatibility mode is often enabled by default for internal websites. The implementation in IE is pretty dire, in that it only allows a whole domain being put into or out of the compatibility list (i.e. 'google.com'). Using the same IE browser and browsing 'external' sites shows that IE is capable of rendering the content, so it's just the compatibility view that's breaking it. Unfortunately the JavaScript error does not lead to investigation of the problem, so this may need to be a known issue for the 2.6 release; but for organisations that have a heavy IE presence it may be a blocking issue for those wishing to upgrade from 2.5. To test this, with a Windows install which has IE installed, run a local copy of Gerrit and point the browser at your local host's canonical name (i.e. my.host.google.com instead of localhost). Go to a change, and click on a diff (unified/side-by-side in the patch set) and the window fails to display. Alternatively click on the name of a file (i.e. https://gerrit-review.googlesource.com/#/c/45261/3/gerrit-httpd/src/main/java/com/google/gerrit/httpd/HttpCanonicalWebUrlProvider.java) and you will get a mostly empty screen.
Jun 7, 2013
#1
alex.ble...@gmail.com
Jun 7, 2013
This was tested with IE9, if it makes a difference.
Jun 8, 2013
The microsoft KB article is gone.
Jun 10, 2013
I doubt it was very helpful, even when it was there. There's a documentation page on compatibility view here: http://windows.microsoft.com/en-gb/internet-explorer/products/ie-9/features/compatibility-view Unfortunately the compatibility view (a) can only be disabled on a per-domain setting (not on a per host or per url) and (b) tends to have unwanted effects even when it does. I think if we had a GWT.setUncaughtExceptionHandler in the client it would make it easier to debug these problems when they occur, because the final try/catch chain ends up masking the stacktrace (in IE at least) of where the real error occurred.
Jun 10, 2013
http://www.gwttutorial.com/gwt-development/global-exception-handling-in-gwt might be useful, for example.
Jun 10, 2013
So this change occurred when the prettify version was updated (with thanks to Edwin for finding it). Rolling back this change fixes the problem in IE in compatibility mode, although that's unlikely to be practical for other browsers. https://gerrit-review.googlesource.com/41850 The change can also be worked around by setting a user's individual preferences to not show syntax highlighting in diffs. Unfortunately this defaults to 'true' for all new accounts, and there isn't a way of setting this via a configuration.
Jun 12, 2013
I seems there where fixes in prettify.js regarding IE shortly after the version in gerrit was updated. (see http://google-code-prettify.googlecode.com/svn/trunk/CHANGES.html)
Jun 12, 2013
I tried with the HEAD version of prettify but that failed as well. I think this is the IE change mentioned in the change log: https://code.google.com/p/google-code-prettify/source/detail?r=239
Aug 22, 2013
Issue 2029 has been merged into this issue.
Sep 10, 2013
I have confirmed that this is a problem in 2.7-rc4 as well (presumably 2.7-rc5 as well, will test that shortly).
Sep 10, 2013
Confirmed in 2.7-rc5, and as a note, this is not limited to compatibility mode, this is also a problem in "real" IE 8 (probably goes without saying, but best to be clear).
Sep 30, 2013
Is this fixed by https://gerrit-review.googlesource.com/49900 ?
Oct 1, 2013
We've found it's better to revert prettify to the previous version (instead of upgrading it) if you're running 2.7 or less. I have a patch for this, but have not submitted it since I assumed it would not be accepted on the already released versions. So the issue is fixed going forward, but not with 2.7 or less without my patch (or a similar patch)
Oct 2, 2013
(No comment was entered for this change.)
Status:
Submitted
Labels: FixedIn-2.8
Dec 9, 2013
(No comment was entered for this change.)
Status:
Released
|
|
| ► Sign in to add a comment |