My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 1951: Show Patch Set in Reverse Order get corrupted after changing commit message
1 person starred this issue and may be notified of changes. Back to list
Status:  Duplicate
Merged:  issue 1801
Owner:  ----
Closed:  Jun 2013


Sign in to add a comment
 
Project Member Reported by David.Os...@gmail.com, Jun 7, 2013
************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version:2.6

What steps will reproduce the problem?
1. [x] Settings > Preferences > Display Patch Sets In Reverse Order
2. Go on change screen
3. Edit commit message
4. Submit

What is the expected output?
Patch sets are still in reverse order

What do you see instead?
After submitting the commit message and reloading the change screen the patch sets are not in reverse order any more

Please provide any additional information below.
inline edit series suffers from the same problem:
https://gerrit-review.googlesource.com/#/c/46194/

Apparently the ChangeDetail event is dispatched twice in the method:

public void onValueChange(final ValueChangeEvent<ChangeDetail> event)

and PatchSetsBlock.display() method is called twice too, with

[...]
Collections.reverse(patchSets);
[...]
Jun 18, 2013
Project Member #1 David.Os...@gmail.com
Is a duplicate of https://code.google.com/p/gerrit/issues/detail?id=1801.

The original issue was fixed.
Jun 20, 2013
Project Member #2 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: Duplicate
Mergedinto: 1801
Sign in to add a comment

Powered by Google Project Hosting