My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 1944: Array index 1724 out of range, in Chrome, not Firefox, when comparing a quite large file
1 person starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  Jun 2013


Sign in to add a comment
 
Reported by l13uw3hu...@gmail.com, Jun 3, 2013
************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version:
Gerrit 2.5.2, Chrome 27, Firefox 21

What steps will reproduce the problem?
1. Hacking on a quite large PHP file (>6k lines)
2. commit and push to gerrit
3. try to see the side-by-side diff, or the unified diff. Both give 'Array index 1724 out of range' on Chrome, not firefox.

What is the expected output? What do you see instead?
Expected output is a diff, preferably with intra-line highlighting
As the javascript fails, I do not move to the next file in the review process and stay on the current file.

Please provide any additional information below.
Tested on Chrome and Firefox. Firefox works fine, Chrome doesn't. I cleared the Gerrit cache (gerrit flush-caches) and Chrome cache.
As the code is for a customer's project I can not post the file or ajax response JSON here.

I'm willing to do some debugging myself, but i need pointers on where to start.
Jun 3, 2013
#1 sop@google.com
I'm fairly certain we fixed this in 2.6. I think it happens when there is no trailing LF at the end of the file in one of the versions (either old or new).
Status: Submitted
Labels: FixedIn-2.6
Jun 3, 2013
#2 l13uw3hu...@gmail.com
any hints on when 2.6 will be release? I'm waiting on it, as it contains a few nice features i want to use....
Jun 3, 2013
#3 l13uw3hu...@gmail.com
it seems to be an issue with this specific file, in another (small) change on the same file, the diff wont be shown as well. For now, I'll wait for 2.6, and report my findings
Sep 20, 2013
#4 l13uw3hu...@gmail.com
I've tested this issue, and it seems to be solved in v2.7. The issue can be closed IMHO
Sep 20, 2013
Project Member #5 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting