| Issue 194: | Support diffs between Patch Sets | |
| 47 people starred this issue and may be notified of changes. | Back to list |
Sign in to add a comment
|
Reported by Cedric Beust <cbeust@google.com> on Wed May 27 13:05:53 PDT 2009 Source: JIRA GERRIT-194
Sep 24, 2009
#1
code-rev...@gtempaccount.com
Sep 24, 2009
Comment by Cedric Beust <cbeust@google.com> on Mon Aug 31 14:45:16 PDT 2009 No, it's more ambitious (and I think more useful): the history should be selectable on the patch set screen and it should adjust the list of files depending on what patch sets are being compared.
Sep 24, 2009
(No comment was entered for this change.)
Status:
Accepted
Owner: ---
Sep 24, 2009
Issue 128 has been merged into this issue.
Sep 24, 2009
(No comment was entered for this change.)
Cc:
cbeust
Jun 14, 2010
Issue 595 has been merged into this issue.
Aug 20, 2010
Hi Shawn, Ulrik asked me to take a look in this issue to see if is possible to solve it. Do you know if is there already anybody working on this? Thanks
Aug 20, 2010
I suspect not. I asked Anatol to look at it, but I don't think he has started.
Owner:
ulrik.sj...@sonyericsson.com
Aug 31, 2010
Hey Lincoln, are you working on it?
Sep 1, 2010
Hi Anatol, I haven't started yet, Have you already started working on this?
Sep 7, 2010
No I haven't but I think about it. I you haven't started it then I try to improve PatchSet list screen.
Sep 8, 2010
Hi Anatol, please feel free to ask Shawn to change the ownership to you.
Dec 16, 2010
Hi Anatol! I work in Ulrik's team and just to clarify, are you working on this feature?
Jan 10, 2011
Hi, Monica. No, I had not time to look at this issue.
Jan 11, 2011
Hi! Do you have plans to work on this or could we start looking at it? Thanks.
Mar 22, 2011
I am curious if anyone is working on this, it seems to be stale? I have several suggested ideas for this issue/feature. 1) It would be nice to have two extra columns with radio buttons (old version/new version) on the ChangeScreen. These buttons would appear to the right of "> Patch Set #" and to the left of the commitID for each patchset. Naturally, they would act like the Patch History button on the Patch Diff Screen. Since there is no patch set 0, an additional entry could be created above Patch Set 1 (and below the Dependencies panel) for the Base entry. Perhaps this would only appear if oldversion had been changed? To strengthen this feature, it would be great if the old version were preset to an appropriate option if a person is currently logged in. Perhaps that would be the last patchset commented on, or reviewed by that person? 2) The second feature would be the filtering of the filelist based on a selected oldversion other than base. This feature could mean that an additional filelist could appear on the changescreen whenever a version other than base is suggested. This filelist could live either above or (likely better) directly below the last patchset. Along with feature 1, this would mean that when a reviewer comes back to look at a new patchset, they will likely see a smaller filelist by default since the base will be set to the previous patchset. This might look best if the latest patchset were additionally "closed" in this case.
Mar 23, 2011
Yes, we are on this, it's about to be ready... What we have been doing is: 1) there will be a combobox within the change screen so that the user will be able to select the comparison reference (master, ps1, ps2 ...). 2) The content of column size for each patch set will be rendered according to the combobox selection. 3) When clicking in side-by-side, the patch history values will inherit the comparison bases from change screen, the old version will be the combobox value and the new version will be the patch set from which the user clicked in side-by-side. 4) Inside the change screen, if you have for instance 10 patch sets and you select patch set 5 in the combo, the patchs 1, 2, 3 and 4 will have their text in red to indicate that the comparison is reverse. This is important to avoid misunderstandings because if the comparison base is ps5, probably the ps1 might show some files from ps5 as deleted, when actually they just haven't been created. We had discussions upon this internally, we have considered applying the comparison selection for each patch set as well, but after all we figured out that this solution would have less code and less UI change... what do U think?
Mar 23, 2011
I'm still not clear on what will be shown. What I really need is only the differences between two branches. So for example, I branch off of master, make 5 changes to the topic branch. I now only want to see the differences between master(c0) and the final commit in the topic branch (c5). I don't need to see every single commit between the two and I'm not sure if that is what you are describing. I like the ability to see a diff between c2 and c5 but for that case I wouldn't want to see c3 and c4 at all unless the changes are still present at c5. As an aside, we very recently did a comparison of Review Board and Gerrit at my company and the ability to review the final difference of a topic branch prior to merging back to master was the killer feature that kept us from recommending Gerrit. Thanks!
Apr 11, 2011
carlosed...@sonyericsson.com: I think I understand what you are doing, and it makes more sense then what I proposed in "Comment 16, (1)" since you only need to select the base (old version), naturally the new version is each patchset. It also eliminates the need for my suggestion (2). I like it! When can we get it? :) I think that the piece I suggested about setting the default base would still be nice, but I would expect that to be a later change at this point since it is just icing on the cake, and the heuristics might be hard to get right. What you propose is the really important stuff. kiy...@gmail.com: I think that what you are talking about makes a lot of sense too, but if I understand you correctly, I think that it is somewhat unrelated to most of this thread. I sounds more like an idea for the "topic branches" idea/issues?
Apr 25, 2011
It's ready. Just pending push or some extra internal review...
May 19, 2011
(No comment was entered for this change.)
Status:
Submitted
Labels: FixedIn-2.1.7
May 31, 2011
(No comment was entered for this change.)
Status:
Released
Dec 20, 2012
(No comment was entered for this change.)
Blocking:
-gerrit:22 -gerrit:10 -gerrit:106 -gerrit:379 gerrit:22 gerrit:10 gerrit:106 gerrit:379 gerrit:379
|
||||||||||
| ► Sign in to add a comment | |||||||||||