My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 1916: Multiple commits with same change-id should be accepted and compiled
1 person starred this issue and may be notified of changes. Back to list
Status:  WontFix
Owner:  ----
Closed:  May 2013


Sign in to add a comment
 
Reported by cookieca...@gmail.com, May 15, 2013
Gerrit should allow me to submit a series of commits with the same change-id and register each subsequent commit as a new patchset. This keeps progression and history information in the raw git repository without introducing the external dependency of Gerrit's tracking.

Alternately, Gerrit should implement a new tag called "series-id" or similar, which would more easily allow branch-level review and tracking that comprised multiple commits. Perhaps that's a different issue altogether.

I want to use Gerrit for code review on some projects as I believe its integration with Git and review featureset is unmatched among code review tools. However, Gerrit's destructive attitude to commit history wherein it forces amendment to the same commit to submit revisions is unacceptable to me as a git purist interested in recording processes as well as final results.

Ultimately, all forcible dependencies on rewritten histories should be removed from the standard workflow. I'm surprised this behavior made it in, to be honest.

Another suggested approach:

  * Initial submissions get change-id tags
  * Revised submissions get revision-parent tags, matching change-id
  * A series of commits to be reviewed as a single unit provision a change-id from Gerrit, and then label each patch as a member of a series-id with the unique identifier string returned from Gerrit's provisioning process.

Would really love to see this kind of control in the near future.
May 15, 2013
#1 sop@google.com
(No comment was entered for this change.)
Status: WontFix
May 15, 2013
Project Member #2 bklarson@gmail.com
Maybe play around with the topic branch feature?
Sign in to add a comment

Powered by Google Project Hosting