| Issue 1914: | Patch sets should have a permalink just like the review (to be linkable/bookmarkable) | |
| 2 people starred this issue and may be notified of changes. | Back to list |
Individual Patch Sets in a review should be linkable using a "Permalink" similar to the one for the whole review. Accessing a Patch Set permalink URL should open its review with only the given Patch Set expanded (all other patch sets, even the latest on, should be in a collapsed state) and navigate to the Patch Set's page anchor (<a name>) - which currently isn't provided/generated.
Sep 20, 2013
#1
nemow...@gmail.com
Sep 24, 2013
A bit similar, yes, but relating to a different proposed functionality. First, a third party example: http://pandas.pydata.org/pandas-docs/dev/io.html On that documentation page, hover over the title of a section - e.g. "CSV & Text files" - a paragraph mark will appear that's an anchor link to that paragraph. You can copy this link to clipboard, follow it or bookmark it. The link is a means to navigate straight to that section on that page. Now take a look at a Gerrit review page (https://gerrit.server.hostname/gerrit/#/c/REVIEW_NUMBER/) for a review which has multiple (more than 1) patch sets. The latest patch set is the one in the expanded state, and the earlier patch sets of the review are collapsed. Upon opening the page, no jumping/scrolling takes place within the document. What I propose is that all the patch sets in the review would receive anchors (<a name="/c/REVIEW_NUMBER/p/PATCHSET_NUMBER">). Then, the JS logic of the view would make sure that if the review page has been visited with a patchset anchor present within the URI's fragment identifier, it would: 1) expand this particular patchset instead of the latest patch set, 2) other patch sets would be left collapsed, 3) it would scroll/jump to the particular referenced patch set's anchor location within the whole page (I think the standard browser logic should take care of this, but I suspect that the collapsing/expanding JS logic could interfere with this browser behaviour).
Sep 24, 2013
BTW, I forgot to add that the anchors should have a visible element - their "<a name>" tag should not be empty, but contain some "permalink" symbol icon that would make them visible and clickable. Here's one permalink icon in SVG format that's licenced under CC: http://wiki.ubc.ca/File:Permalink.svg Other conventions for labelling/visualizing permalinks are also possible - see: http://en.wikipedia.org/wiki/Permalink#Presentation
Feb 6, 2014
The first step would be making the /N suffix in links actually open the patchset in question: if I pick a diff from a patchset, the link "up to change" brings me to a URL in the form https://gerrit.wikimedia.org/r/#/c/111176/2 , but patchset 2 is not expanded. I thought it did, but it doesn't as of 2.8.1. |
|
| ► Sign in to add a comment |