| Issue 191: | hints may lead reviews to be misassigned | |
| Back to list |
Reported by Andrew D. Stadler (Google) <stadler@android.com> on Tue May 26 08:32:23 PDT 2009 Source: JIRA GERRIT-191 I have a change that I'd like to ask Bob Lee to review. However, when I type "bob lee" or "crazybob" into gerrit all I get is a non- google, non-android address "Bob Lee <crazybob@crazybob.org>". I know Bob so it's a reasonable guess that this is really him. But what if it's not? I don't want to be sending random CL's to random people, or even worse what if somebody signed up a bunch of fake "almost" addresses to try and divert legitimate code reviews. I know this probably isn't super serious but it smells fishy, like there's an exploit in there. At best, it's annoying not to get hints for the people we're actually looking for.
Sep 24, 2009
#1
code-rev...@gtempaccount.com
Sep 24, 2009
Update by Shawn Pearce <sop@google.com> on Tue May 26 09:14:10 PDT 2009 Change description to: ---- I have a change that I'd like to ask Bob Lee to review. However, when I type "bob lee" or "crazybob" into gerrit all I get is a non- google, non-android address "Bob Lee <crazybob@crazybob.org>". I know Bob so it's a reasonable guess that this is really him. But what if it's not? I don't want to be sending random CL's to random people, or even worse what if somebody signed up a bunch of fake "almost" addresses to try and divert legitimate code reviews. I know this probably isn't super serious but it smells fishy, like there's an exploit in there. At best, it's annoying not to get hints for the people we're actually looking for. ----
Sep 24, 2009
Comment by Shawn Pearce <sop@google.com> on Mon Jun 08 18:24:11 PDT 2009 Fixed by https://review.source.android.com/10309 But... in the case of the one user account you mentioned (crazybob), he has no @google.com address registered with Gerrit. So you'll never get an @google.com address completion. If he has an @google.com, try to encourage him to link his GAIA account to the existing account in Gerrit, so you can use it to add him as a reviewer.
Sep 24, 2009
Update by Shawn Pearce <sop@google.com> on Mon Jun 08 18:24:11 PDT 2009 Fixed in version 2.0.14.
Status:
Fixed
Sep 25, 2009
(No comment was entered for this change.)
Labels:
FixedIn-2.0.14
Oct 25, 2012
(No comment was entered for this change.)
Status:
Released
|
|
| ► Sign in to add a comment |