My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 1907: Support topic within commit message
1 person starred this issue and may be notified of changes. Back to list
Status:  Invalid
Owner:  ----
Closed:  Aug 2013


Sign in to add a comment
 
Reported by alon.barlev@gmail.com, May 8, 2013

Currently gerrit supports topic when change is pushed, this is a great eye catcher and simple group management in UI.

However, the topic is overridden to any patch that is modified.

Previous topic is lost after rebase.

Example:
---
$ git checkout master
$ git commit -m "commit1"
$ git checkout -b topic1
$ git commit -m "commit2"
$ git push upstream HEAD:refs/for/master/topic1
$ git checkout -b topic2
$ git commit -m "commit3"
$ git push upstream HEAD:refs/for/master/topic2

At this point all is OK:
1. commit2 is assigned to topic1
2. commit3 is assigned to topic2

$ git checkout master
$ git commit -m "commit4"
$ git checkout topic2
$ git rebase master
$ git push upstream HEAD:refs/for/master/topic2

Now... commit2 is assigned to topic2 although is should be topic1.
---

What I recommend is to add a line of Change-Topic: similar to Change-Id: to allow assignment of topic based on commit message. This way the grouping of commits will stay intact after cherry-picks and rebases.

Thank you!

Aug 23, 2013
#1 alon.barlev@gmail.com
This is not important right now, as gerrit-2.6 allows editing topic at web UI.

But I cannot close this, have no permission.
Aug 23, 2013
Project Member #2 edwin.ke...@gmail.com
Closing as requested.
Topics can now be edited from the WebUI.
Status: Invalid
Sign in to add a comment

Powered by Google Project Hosting