My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 1905: OpenID Login Window Broken - 2.6-rc2, 2.7.rc0
2 people starred this issue and may be notified of changes. Back to list
Status:  WontFix
Owner:  ----
Closed:  May 2013


Sign in to add a comment
 
Reported by 10kylelaker@gmail.com, May 7, 2013
Affected Version:
2.6-rc2, 2.7-rc0 (2.6-rc1 untested, did not exist in 2.6-rc0)
What steps will reproduce the problem?
1. Choose "Sign in" from any Gerrit page
2. Window that appears isn't how it should be
3.

What is the expected output? What do you see instead?
The window should just kinda pop over what always is there, but instead it is a full, unstyled window. No CSS, just HTML.

Please provide any additional information below.
No problems with GerritSiteHeader/GerritSiteFooter.html or GerritSite.css.
May 7, 2013
#1 sop@google.com
Its not broken, that is an expected change in 2.6 (and thus 2.7).
Status: WontFix
May 7, 2013
#2 10kylelaker@gmail.com
See the attachment. If this is intended, maybe it should be reconsidered...
Screenshot_2013-05-07-20-31-16.png
131 KB   View   Download
Jul 22, 2013
#3 aaronwells
This issue is still present in 2.6.1. For comparison, here's what the login "popup" from 2.5 looked like.

The new login screen works in the sense that you can log in. But it's broken, in the sense that virtually all its styling is missing. I suspect the problem is that when it was converted from a "popup" into a standalone page, the proper standalone page styling info wasn't added to it.
gerrit15openid.png
233 KB   View   Download
Jul 22, 2013
#4 aaronwells
I've opened a separate issue to address the lack of CSS styling, rather than the fact that it's no longer in a popup: https://code.google.com/p/gerrit/issues/detail?id=2027
Sign in to add a comment

Powered by Google Project Hosting