| Issue 1904: | Cannot display diff when file contains CRLF line feeds | |
| 13 people starred this issue and may be notified of changes. | Back to list |
Affected Version: 2.6-rc1 What steps will reproduce the problem? 1. Go to a random review, click preferences, and uncheck "Show line endings". Click save. 1. Create a change with new lines ending in CRLF (possibly you need to delete a few lines too). 2. Go to the review in your browser. Click on a file. What is the expected output? What do you see instead? The diff should be displayed in the browser, but nothing happens. If I "open in a new tab", the header and general page layout is displayed but not the diff. Please provide any additional information below. The javascript seems to fail with a Uncaught Class$S1623: Array index 236 out of range (where 236 changes depending on the diff). The problem goes away when I uncheck "Show line endings" in the UI, or when I look at files with \n line endings and not \r\n.
Jun 24, 2013
#1
paragsa...@gmail.com
Jul 1, 2013
(No comment was entered for this change.)
Status:
Submitted
Labels: FixedIn-2.6
Jul 1, 2013
https://gerrit-review.googlesource.com/47421 |
|
| ► Sign in to add a comment |