My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 190: Can't add reviewer; silent failure
  Back to list
Status:  Released
Owner:  code-rev...@gtempaccount.com
Closed:  Oct 2012


Sign in to add a comment
 
Reported by code-rev...@gtempaccount.com, Sep 24, 2009
Reported by Andrew D. Stadler (Google) <stadler@android.com> on Mon May 25 18:25:20 PDT 2009
Source: JIRA GERRIT-190

I'm trying to add a new reviewer to <https://android-git.corp.google.com/g/
Gerrit#change,2424>

I typed "danfuzz@android.com" and clicked "add reviewer" and it worked
properly.

Then I typed "mscherer@google" and clicked "add reviewer" and nothing
happened.  And there was no diagnostic so I don't know why if failed.
Sep 24, 2009
#1 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Tue May 26 07:54:14 PDT 2009

My guess is, you missed the ".com" bit, so it wasn't a complete email.  But
yes, Gerrit should have told you it can't find the user given the input you
supplied.
Sep 24, 2009
#2 code-rev...@gtempaccount.com
Comment by Andrew D. Stadler (Google) <stadler@android.com> on Tue May 26 08:19:41 PDT 2009

Just retried, and confirmed that with the full email address (@google.com) it
is failing.  "@google" was just a typo in the bug report (sorry).
Sep 24, 2009
#3 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Mon Jun 08 18:43:29 PDT 2009

Fixed by https://review.source.android.com/10310
Sep 24, 2009
#4 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Mon Jun 08 18:43:29 PDT 2009

Fixed in version 2.0.14.
Status: Fixed
Sep 25, 2009
#5 code-rev...@gtempaccount.com
(No comment was entered for this change.)
Labels: FixedIn-2.0.14
Oct 25, 2012
#6 sop@google.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting