My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 1893: Multiple errors, when trying to review differences.
15 people starred this issue and may be notified of changes. Back to list
Status:  WontFix
Owner:  ----
Closed:  Nov 2013


Sign in to add a comment
 
Reported by snowm...@gmail.com, Apr 29, 2013
Affected Version: 2.6-rc1

When I click on some file in some change, to see diff, I caught one of two possible errors:

1. I can see side-by-side diff, but have javascript error tells 404 on https://server/gerrit/changes/1035/revisions/1/files/some_file_name/reviewed and reviewed tick doesn't appear

OR

2. Nothing happens and diff doesn't even open with javascript error like
"Uncaught Class$S1623: Array index 520 out of range 5471FCBADDA3EC27CC2BB154B96DA06C.cache.html:1946"

I've tried this many times on many browsers, whth english and russian locale, and couldn't figure some rules out in gerrit behavior.
Apr 29, 2013
#1 snowm...@gmail.com
Maybe it's important addition:
I have migrated to 2.6-rc1 from 2.5-rc0.
Apr 29, 2013
#2 kbeklemi...@gmail.com
caught by firebug:

uncaught exception: Class$S1620: Array index 461 out of range
function iMb(){try{null.a()}catch(a){return a}}
Jun 20, 2013
#3 justin.s...@gmail.com
Several of our developers were seeing this error after we upgraded from 2.5.x. We compared settings and preferences between a working dev and a non-working dev and discovered that enabling the 'Show Line Endings' option in the diff preferences fixed the error.
Jun 24, 2013
#4 paragsa...@gmail.com
Duplicate for  Issue 1885 
Jul 1, 2013
#5 diwa...@maginatics.com
We hit the same issue and the workaround in comment #3 worked (thanks @justin!). Given that this is a (really annoying) regression from 2.5, I'd request a 2.6.x minor release that fixes this bug.
Sep 17, 2013
#6 sam.hend...@gmail.com
+1 for this issue. Still occuring in 2.6.1
Sep 18, 2013
#7 xla...@gmail.com
maybe it will help this hint:

if i try to view the diff under the user who commit the change then the diff is showed. Still, in javascript console some error are logged: a 404 code for file not found; after a closser look the 404 is for PUT and DELETE on reviewed because it's looks like also the Reviewed checkbox is having no effect.

All the other users who have not  commit the change, get a javascript error like in comment #2 when they want to view the diff

uncaught exception: Class$S1623: Array index 92 out of range

function rMb(){try{null.a()}catch(a){return a}}
Sep 19, 2013
#8 xla...@gmail.com
i just updated to 2.7 and the side by side diff is working under both users.
The error regarding the checkbox for reviewed is still not working and errors for PUT and DELETE are still present 
Sep 26, 2013
#9 casta...@motorola.com
+1 for this issue as well.  Would like to see it fixed in 2.6.2 if possible.
Nov 12, 2013
#10 sop@google.com
The URL is correct. Do you have an Apache proxy in front? If so you need to update its configuration.

https://gerrit-review.googlesource.com/Documentation/config-reverseproxy.html#_apache_2_configuration
Status: WontFix
Nov 12, 2013
#11 docw...@gmail.com
Which part? I'm not at work but I'm pretty sure we have it configured with the new settings, but we had the same problems too.  I know we have nocanon and the AllowEncodedSlashes part.

Ciao!


Sign in to add a comment

Powered by Google Project Hosting