My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 189: Please add more status indications to the #mine page
  Back to list
Status:  Released
Owner:  code-rev...@gtempaccount.com
Closed:  Oct 2012


Sign in to add a comment
 
Reported by code-rev...@gtempaccount.com, Sep 24, 2009
Reported by Andrew D. Stadler (Google) <stadler@android.com> on Fri May 22 15:18:30 PDT 2009
Source: JIRA GERRIT-189

This is primarily for the middle section, "reviewable by Andrew Stadler".
Even if I've reviewed a change, there is no indication in the dashboard.  It
may stay there for days or weeks until submitted.  So now when I visit my
dashboard, I still have to manually click line items to see what shape they're
in.

Request:  Please add some indication that I've reviewed each element in the
middle section.

Specific suggestions:
(a) Do it using similar color codes to Mondrian.
(b) Add two narrow columns for "reviewed" and "verified" and give me the
familiar green checkmarks when I've done so.  Then at least I can simply look
for unreviewed lines.

Extra credit:  The same change would be useful in the first section, "Started
by Andrew Stadler", but the semantic is slightly different:  I need to know if
anybody else has reviewed/verified the change.
Sep 24, 2009
#1 code-rev...@gtempaccount.com
Update by Cedric Beust <cbeust@google.com> on Thu Jul 16 10:03:41 PDT 2009
Status: Fixed
Sep 24, 2009
#2 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Thu Jul 16 10:06:09 PDT 2009

Uh, fixed by what, and closed why?
Sep 24, 2009
#3 code-rev...@gtempaccount.com
Comment by Cedric Beust <cbeust@google.com> on Thu Jul 16 10:10:16 PDT 2009

I misunderstood this bug, reopening.
Sep 24, 2009
#4 code-rev...@gtempaccount.com
Update by Cedric Beust <cbeust@google.com> on Thu Jul 16 10:10:16 PDT 2009
Status: New
Sep 24, 2009
#5 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Wed Aug 19 11:20:11 PDT 2009

A recent thread on repo-discuss may be relevant:

  http://groups.google.com/group/repo-discuss/browse_thread/thread/5767a9bd67fe6634
Sep 24, 2009
#6 code-rev...@gtempaccount.com
Comment by Zach Wily <zach@zwily.com> on Mon Aug 31 21:32:04 PDT 2009

I think there would need to be as many columns as there are review statuses -
it can't be hard-coded. (For example, we don't use the Verified status and
have removed it from the database.)
Sep 24, 2009
#7 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Thu Sep 03 07:56:27 PDT 2009

Fixed by I131e6c4c62ad336a6a1188d5c2161f0174923f42
Sep 24, 2009
#8 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Thu Sep 03 07:56:27 PDT 2009

Fixed in version 2.0.21.
Status: Fixed
Sep 25, 2009
#9 code-rev...@gtempaccount.com
(No comment was entered for this change.)
Labels: FixedIn-2.0.21
Oct 25, 2012
#10 sop@google.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting